Move to yarn and force resolution of wait-on to safe axios version #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves this repo to using yarn and uses resolutions for the wait-on package which has addressed the dependabot alerts on axios 0.25. With this new resolution for wait-on it forces the axios version to be 1.6 latest which addresses the issues that are not impacting to the production build of this plugin.
This pr also bumps babel core and adds a dev dependency for babel that allows the plugin to build again.
See also:
WordPress/gutenberg#56069
WordPress/gutenberg#56552
https://github.com/jeffbski/wait-on/releases/tag/v7.2.0
to test:
yarn && yarn run build