SLICE-128 making SliceLookUpTag type attribute value String

README.md

@@ -31,7 +31,7 @@ No more business logic in your view (JSP, Sightly scripts) - business logic's pl
 
 **JSPs made clean and tidy** - no more these ugly scriptlets.
 ```jsp
-<slice:lookup var="model" type="<%=com.example.components.text.TextModel%>" />
+<slice:lookup var="model" type="com.example.components.text.TextModel" />
 <p>${model.text}</p>
 ```
 
@@ -220,7 +220,7 @@ Add dependencies to your POM file:
 <dependency>
 	<groupId>com.cognifide.slice</groupId>
 	<artifactId>slice-core-api</artifactId>
-	<version>4.3.0</version>
+	<version>5.0.0</version>
 </dependency>
 <dependency>
 	<groupId>com.cognifide.slice</groupId>

slice-core-api/pom.xml

@@ -72,6 +72,11 @@
 			<artifactId>org.osgi.core</artifactId>
 		</dependency>
 
+		<dependency>
+			<groupId>org.apache.sling</groupId>
+			<artifactId>org.apache.sling.commons.classloader</artifactId>
+		</dependency>
+
 		<!-- javax -->
 		<dependency>
 			<groupId>javax.servlet</groupId>

slice-core-api/src/main/java/com/cognifide/slice/api/tag/SliceLookupTag.java

@@ -33,7 +33,7 @@ public class SliceLookupTag extends SimpleTagSupport {
 
 	private String appName; // auto-detected when null
 
-	private Class<?> type;
+	private String type;
 
 	private void clean() {
 		type = null;
@@ -49,14 +49,17 @@ public void doTag() throws JspException {
 			}
 
 			final PageContext pageContext = (PageContext) getJspContext();
-			final Object model = SliceTagUtils.getFromCurrentPath(pageContext, type, appName);
+			final Class typeClass = SliceTagUtils.getClassFromType(pageContext, type);
+			final Object model = SliceTagUtils.getFromCurrentPath(pageContext, typeClass, appName);
 			pageContext.setAttribute(var, model, PageContext.PAGE_SCOPE);
+		} catch (ClassNotFoundException e) {
+			throw new JspTagException("Could not get class for " + type);
 		} finally {
 			clean();
 		}
 	}
 
-	public void setType(Class<?> type) {
+	public void setType(String type) {
 		this.type = type;
 	}
 

slice-core-api/src/main/java/com/cognifide/slice/api/tag/SliceTagUtils.java

@@ -35,6 +35,7 @@
 import com.cognifide.slice.api.injector.InjectorWithContext;
 import com.cognifide.slice.api.injector.InjectorsRepository;
 import com.cognifide.slice.api.provider.ModelProvider;
+import org.apache.sling.commons.classloader.DynamicClassLoaderManager;
 
 public final class SliceTagUtils {
 
@@ -73,6 +74,22 @@ public static <T> T getFromCurrentPath(final PageContext pageContext, final Clas
 		return getFromCurrentPath(request, injectorsRepository, requestContextProvider, type, appName);
 	}
 
+	/**
+	 * A helper method that returns the {@link Class} object, resolving it via it's Canonical Name.
+	 *
+	 * @param pageContext allows to access request context
+	 * @param type canonical name of the modal object, whose {@link Class} object needs to be returned
+	 * @return {@link Class} object pertaining to {@code type} as it's canonical name
+	 * @throws ClassNotFoundException if the class was not found
+	 */
+	public static Class<?> getClassFromType(final PageContext pageContext, final String type) throws ClassNotFoundException {
+		final SlingScriptHelper scriptHelper = getSlingScriptHelper(pageContext);
+		final DynamicClassLoaderManager dynamicClassLoaderManager = scriptHelper
+				.getService(DynamicClassLoaderManager.class);
+		final ClassLoader classLoader = dynamicClassLoaderManager.getDynamicClassLoader();
+		return classLoader.loadClass(type);
+	}
+
 	/**
 	 * A helper method that returns a model of the Sling resource related to given request
 	 *

slice-core-api/src/main/java/com/cognifide/slice/api/tag/package-info.java

@@ -17,7 +17,7 @@
  * limitations under the License.
  * #L%
  */
-@Version("4.3.0")
+@Version("5.0.0")
 package com.cognifide.slice.api.tag;
 
 import aQute.bnd.annotation.Version;

slice-test/slice-core-test/src/test/groovy/com/cognifide/slice/api/tag/SliceTagUtilsTest.groovy

@@ -0,0 +1,62 @@
+/*-
+ * #%L
+ * Slice - Core Tests
+ * %%
+ * Copyright (C) 2012 Cognifide Limited
+ * %%
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * #L%
+ */
+
+package com.cognifide.slice.api.tag
+
+import com.cognifide.slice.test.setup.BaseSetup
+import org.apache.sling.api.scripting.SlingBindings
+import org.apache.sling.api.scripting.SlingScriptHelper
+import org.apache.sling.commons.classloader.DynamicClassLoaderManager
+import org.junit.Assert
+
+import javax.servlet.ServletRequest
+import javax.servlet.jsp.PageContext
+import java.lang.reflect.Method
+
+/**
+ * @author Shashi Bhushan
+ * Date: 23.08.16
+ */
+class SliceTagUtilsTest extends BaseSetup {
+
+    def "Get Class object, given the String type"() {
+        given:
+        final PageContext pageContext = Mock(PageContext){
+            getRequest()>>  Mock(ServletRequest){
+                getAttribute(_ as String) >> Mock(SlingBindings) {
+                    getSling() >> Mock(SlingScriptHelper) {
+                        getService(_ as Class) >> Mock(DynamicClassLoaderManager) {
+                            getDynamicClassLoader() >> Mock(ClassLoader) {
+                                loadClass(_ as String) >> SliceTagUtils.class
+                            }
+                        }
+                    }
+                }
+            }
+        }
+
+        when:
+        Class aClass = SliceTagUtils.getClassFromType(pageContext, "com.cognifide.slice.api.tag.SliceTagUtils");
+
+        then: "aClass object should not be null and should be equal to expected Class"
+        Assert.assertNotNull(aClass)
+        Assert.assertEquals(SliceTagUtils.class, aClass);
+    }
+}