Skip to content

Bugfix/red highlight for too big asset #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Bugfix/red highlight for too big asset #605

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
78763d1
Modify table in request monitoring
Dec 2, 2020
af59e65
Additional section with unexpected assets
Dec 2, 2020
b8655b1
Change ng-if for item with danger style
Dec 4, 2020
705f463
Remove console log and comment part of code for colouring failing ite…
Dec 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions report/src/main/webapp/app/layout/main/url/reports/request-monitoring.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,29 @@ <h4>Total size: {{case.result.totalSize.toFixed(2)}} kB</h4>
</tr>
</thead>
<tbody>
<tr ng-repeat="item in case.result.results">
<!-- TO DO: Uncomment and test if it's working after implementing improvement checking max size for one specific item-->

<!-- <tr class="divider-row" ng-if="case.status == 'FAILED'">-->
<!-- <td colspan="4">-->
<!-- Unexpected assets:-->
<!-- </td>-->
<!-- </tr>-->
<!-- <tr class="danger"-->
<!-- ng-repeat="item in case.result.results.size >= maxSize">-->
<!-- <td>{{$index+1}}</td>-->
<!-- <td><a href="{{item.url}}">{{item.url}}</a></td>-->
<!-- <td>{{item.size.toFixed(2)}}</td>-->
<!-- <td>{{item.code}}</td>-->
<!-- </tr>-->
<tr class="divider-row">
<td colspan="4">
All gathered assets:
</td>
</tr>
<tr class="info" ng-repeat="item in case.result.results">
<td>{{$index+1}}</td>
<td><a href="{{item.url}}">{{item.url}}</a></td>
<td>{{item.code}}</td>
<td><a href="{{item.url}}" title="{{item.url}}">{{item.url}}</a></td>
<td>{{item.size.toFixed(2)}}</td>
</tr>
</tbody>
Expand Down