Fix: Use /system/bin/sh on Android for executing commands. #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CommandLineTool.kt was previously hardcoding /bin/bash, which is not available on Android. This change modifies the `runCommand` function to dynamically check the operating system. If the OS is Android, it uses /system/bin/sh; otherwise, it defaults to /bin/bash. This ensures compatibility across different platforms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CommandLineTool.kt was previously hardcoding /bin/bash, which is not available on Android. This change modifies the
runCommandfunction to dynamically check the operating system. If the OS is Android, it uses /system/bin/sh; otherwise, it defaults to /bin/bash. This ensures compatibility across different platforms.@IsHacker03 #5