Support for .NET8 and Tracing information #6628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 20, 2025 14:14
…ct file (or the build switches in it are ignored). Signed-off-by: Konstantina Chremmou <[email protected]>
Signed-off-by: Konstantina Chremmou <[email protected]>
…roperties instead of public fields. Signed-off-by: Konstantina Chremmou <[email protected]>
Signed-off-by: Konstantina Chremmou <[email protected]>
Signed-off-by: Konstantina Chremmou <[email protected]>
…traceparent header. Signed-off-by: Edwin Török <[email protected]>
kc284
force-pushed
the
master
branch
3 times, most recently
from
c7ee5e4 to
251f0af
Compare
…enterism and not always correct. Signed-off-by: Konstantina Chremmou <[email protected]>
edwintorok
approved these changes
Aug 21, 2025
| var state = activity.TraceStateString; | ||
|
|
||
| if (state?.Length > 0) | ||
| requestMessage.Headers.Add("tracestate", state); |
There was a problem hiding this comment.
This is now in a .Net8 specific codepath, and HttpClient is used (not WebRequest), so maybe that one would already do most of this on its own?
Perhaps this could be done more simply if at this line:
httpClient = new HttpClient(httpHandler) { Timeout = TimeSpan.FromMilliseconds(Timeout) };
We add:
httpClient = new HttpClient(httpHandler) { Timeout = TimeSpan.FromMilliseconds(Timeout), ActivityHeadersPropagator = DistributedContextPropagator.CreateDefaultPropagator() };
Although for now we can also keep this code as is (which was tested with WebRequest), and simplify it later.
ElijahSadorra
approved these changes
Aug 22, 2025
Signed-off-by: Konstantina Chremmou <[email protected]>
|
Sorry, I had to add one more commit because there has just occurred an issue with the PS 5.1 build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit authored by Edwin is porting the changes from #5929.