Skip to content

Conversation

xbcsmith
Copy link
Owner

@xbcsmith xbcsmith commented Apr 7, 2025

No description provided.

@xbcsmith xbcsmith requested review from Copilot and jayvdb April 7, 2025 16:05
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • testdata/functest.sh: Language not supported
Comments suppressed due to low confidence (1)

src/main.rs:116

  • Consider adding tests to verify the behavior of the YAML emitter when the '--multiline' flag is enabled.
if multiline {

@xbcsmith xbcsmith mentioned this pull request Apr 7, 2025
@xbcsmith xbcsmith requested a review from Copilot April 7, 2025 17:04
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • testdata/functest.sh: Language not supported
Comments suppressed due to low confidence (1)

testdata/foo.yaml:3

  • [nitpick] Consider using YAML's literal block style (as used in testdata/bar.yaml) for multiline strings to ensure consistent formatting across test cases.
  - bar: "echo 1\necho 2\n"

@xbcsmith xbcsmith requested a review from Copilot April 7, 2025 17:04
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • testdata/functest.sh: Language not supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant