Skip to content

Conversation

lnjX
Copy link
Contributor

@lnjX lnjX commented Apr 26, 2025

Currently the schema says some elements MUST contain a '<reason/>' from urn:xmpp:jingle-message:0 and the examples and specification text said that some elements SHOULD contain a &lt;reason/&gt; element from urn:xmpp:jingle:1.

This does:

  • SHOULD -> MUST contain reason
  • Use reason from urn:xmpp:jingle:1 in both XML schema and examples
  • XEP-0353/JMI: Remove redefinition of jingle reason element in schema
  • XEP-0353/JMI: Make usage of reason element a MUST
  • XEP-0353/JMI: Add version block for 0.7.0

@github-actions github-actions bot added the Needs Author The XEP is experimental and the PR was not made by the author. The author needs to acknowledge it. label Apr 26, 2025
@lnjX lnjX force-pushed the xep-0353/reference-jingle-reason branch 2 times, most recently from 94d02fa to 63c1711 Compare May 3, 2025 16:36
@lnjX
Copy link
Contributor Author

lnjX commented May 3, 2025

Ping @tmolitor-stud-tu :)

@lnjX lnjX force-pushed the xep-0353/reference-jingle-reason branch from 63c1711 to 1053af4 Compare August 7, 2025 17:48
@lnjX
Copy link
Contributor Author

lnjX commented Aug 7, 2025

Ping @fippo @stpeter @tmolitor-stud-tu

and @iNPUTmice :)

@tmolitor-stud-tu
Copy link
Contributor

Unfortunately, afaik, the SHOULD --> MUST requires a namespace bump and we should avoid this.
Doing it the other way round (MUST-->SHOULD) would be okay, though.

@lnjX
Copy link
Contributor Author

lnjX commented Aug 7, 2025

@tmolitor-stud-tu I see. :/ However, the XML schema already had minOccurs=1 maxOccurs=1 before, so the schema already had a MUST before. This is inconsistent, but both conditions, those from the text and those from the XML schema need to be met, or am I wrong?

If so, then a JMI element without the reason element was allowed by the text but not by the XML schema, so it was not valid.
If we also change the text to MUST, then this does not change the behavior, an element without the reason element is still invalid.

However, this is maybe a bit pedantic and I can totally understand if you say this leads to confusion and making the MUST from the schema a SHOULD would be better than the current situation. :)

@stpeter
Copy link
Member

stpeter commented Aug 7, 2025

What do the existing implementations generate and expect?

@lnjX
Copy link
Contributor Author

lnjX commented Aug 13, 2025

xmpp-parses/Rust, slixmpp, movim, dino all ignore the reason element and also don't generate it. I didn't have a look into the code of the other implementations, but it seems like making it optional is the way to go then.

I'll adjust the PR.

@lnjX lnjX marked this pull request as draft August 13, 2025 21:48
Instead import <reason/> element from Jingle namespace, so the XML
schema matches with the examples.
Currently most implementations don't use it, so the best way seems to be
making it optional in the schema, too. The text already says SHOULD.
@lnjX lnjX force-pushed the xep-0353/reference-jingle-reason branch from 1053af4 to e589484 Compare September 16, 2025 19:43
@lnjX lnjX marked this pull request as ready for review September 16, 2025 19:43
@lnjX
Copy link
Contributor Author

lnjX commented Sep 16, 2025

Sorry that this took so long, did the adjustments now. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Author The XEP is experimental and the PR was not made by the author. The author needs to acknowledge it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants