Repository navigation
Add make_batch_constant from std::array in C++20 - #1256
Merged
JohanMabille merged 2 commits intoFeb 19, 2026
Merged
Conversation
Contributor
|
I'm fine with it, please just add a test case ;-) |
Contributor
|
(this requires a C++20 bot, but I'm fine with having this just to make sure we are C++20 compatible too) |
AntoinePrv
force-pushed
the
batch-constant-nttp
branch
from
February 19, 2026 10:08
c25805a to
c4a08e6
Compare
Contributor
Author
|
I added the test. There is already a CI job for testing with C++17 and C++20. |
JohanMabille
left a comment
JohanMabille
left a comment
Member
There was a problem hiding this comment.
Can you also provide a test for make_batch_bool_constant ?
AntoinePrv
force-pushed
the
batch-constant-nttp
branch
from
February 19, 2026 15:45
c4a08e6 to
aad2337
Compare
JohanMabille
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Porposal to add
std::arraytomake_batch_constantwhen building with C++ 20.