[Misc] Update actions/checkout to v7 and let Renovate update the workflow template - #104
Merged
Merged
Conversation
…flow template * Bump actions/checkout to v7 in template-github/docker-build.yml and in .github/workflows/gradlew-check.yml, and regenerate .github/workflows/docker-build.yml. * Add a Renovate custom manager reading the action versions from template-github/, and a package rule disabling updates to the generated .github/workflows/docker-build.yml, so that action bumps land on the template instead of on the file the Gradlew Check action regenerates. A custom manager is needed because the template is not valid YAML before its tokens are expanded, so the native github-actions manager cannot parse it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #86.
#86 (Renovate) bumped
actions/checkoutto v7 in.github/workflows/docker-build.yml, but that file is generated fromtemplate-github/docker-build.yml, which still pinned v4. Merging it would have madeGradlew Checkfail onmaster(it regenerates the file and diffs), and the next./gradlewrun would have silently reverted the bump. Its green checks were misleading: thepull_requesttrigger forGradlew Checkwas only added in 187b5c3, after #86's head was pushed, so that check never ran there.Changes
actions/checkoutto v7 intemplate-github/docker-build.ymland in.github/workflows/gradlew-check.yml(the latter is not generated), and regenerate.github/workflows/docker-build.ymlwith./gradlew.uses:lines fromtemplate-github/**.yml;.github/workflows/docker-build.yml.Notes on the Renovate config
github-actionsmanager's file patterns, because the template is not valid YAML before token expansion —$pathFilterssits at column 0 underpaths:— so the YAML-parsing native manager would silently extract nothing.datasourceTemplate: github-tags+versioningTemplate: dockermirrors the native manager, keeping the repo's major-only pins (v4->v7, notv7.0.1).packageRules+matchFileNamesrather than top-levelignorePaths, which would have replacedconfig:base's default ignore list instead of adding to it.Verification
./gradlewis idempotent on the result — a second run produces no diff, soGradlew Checkpasses.renovate-config-validatorpasses with renovate@44, the version running on this repo (per Update actions/checkout action to v7 #86's debug blob). Worth knowing for future config edits: a plainnpx renovatemay resolve an older 37.x, which rejectsmanagerFilePatterns(renamed fromfileMatchin v41).matchStringsregex was checked to extractactions/checkoutfrom the template, and the file pattern to not match the generated path. A fullrenovate --platform=localextraction was not run — renovate@44 requires Node 24.Left alone as out of scope:
renovate-config-validatoralso flagsextends: config:baseas deprecated in favour ofconfig:recommended. It's pre-existing and Renovate auto-migrates it.🤖 Generated with Claude Code