XRENDERING-766: Macros followed by an empty block with parameters gets wrapped in a span when converted to annotated html - #404
Open
michitux wants to merge 3 commits into
Open
Conversation
…s wrapped in a span when converted to annotated html * Add several failing test cases. * Attempt fixing some of the identified issues - but it's far from complete.
…s wrapped in a span when converted to annotated html * Keep empty syntax at the end of a block when the only other block content is a verbatim or macro syntax. * Add a test for the original scenario of the issue. * Adapt the paragraph test to expect the removal of the empty format. * Add some currently failing XHTML roundtrip tests for the empty format. Note: the behavior should probably be changed again, waiting for answers on forum proposal. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…s wrapped in a span when converted to annotated html * Implement a less breaking option: continue discarding empty format at the end of blocks, still fix: * Format wrongly wraps the macro before it. * Empty format wraps the following paragraph Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira URL
Changes
Description
Clarifications
Screenshots & Video
No direct UI changes.
Executed Tests
Built the whole
xwiki-renderingproject.Expected merging strategy