v3 temporary branch #225
Merged
v3 temporary branch #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @sophiedeziel and the rest of your teammates on |
|
Visit the preview URL for this PR (updated for commit 6de08a8): https://gcode-preview--pr225-v3-x-aqxp7irz.web.app (expires Fri, 22 Nov 2024 22:17:10 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 59bd114ae4847b32c2bba0b68620b9069a3e3531 |
sophiedeziel
changed the title
11 tasks
This was referenced Oct 14, 2024
This was referenced Oct 16, 2024
Merged
* Interpreter prototype * arc support * units * Simplify toolchange * travelType * remove setInches * remove targetId * layers * render lines * extract machine * wip * Make it work with rerenders * Remove some layer references * Rename Machine to Job * Simplify parsing attributes * Am I going too far? * get rid of geometries once used * the geometries disposition is handled by the batchMesh * Fix tests * Bring back some code * Bring back progressive rendering * update dev-gui with job * Test Path * First interpreter tests * Test G0 and G1 * Test everything by G2 * Adding missing codes * Minimize diff on app.js * Leave G21 for a future PR * Job tests (and fixes!) * Keep G28 for a separate PR * Improve tests * Code improvements * Retractions are travel
* Introduce the traveltype indexer * Add the layer indexer * don't clear for all types * Fix the calls to the getters * Cleaner error management * Fix all tests
* Bring back the tolerance logic * Simplify the options
* Remove the code enum (#229) * Bring back a representation of layers * No need to expose isPlanar now * Make layers 100% progressive rendering ready * Layer number, height and z * fix the splitting logic
* Layer number, height and z * fix the splitting logic * partial rendering with clipping * Smoother plane movement * Accurate position of the planes * Clipping works * the clipping is done at the edges of the geometry * Tool indexer for color optimizations * Clipping that works with lines * Fix a bug that rendered only every other line * remove an accidentally duplicated test out of context * Layers work for vase mode * Progressive rendering * remove plane helpers * Single layer mode * Fix the geometries height * Polishing details * Polishing details * Test the tool indexer * Fix clipping and progressive rendering for small files
|
Wow! It's ready! What an amazing achievement! Since we've already discussed many aspects and to not keep you waiting I'll just summarize my first findings based on some black box testing:
But apart from this..... 🎉 everything Just Works™! 🎉 |
I am pretty sure I addressed both recently! Let me see if a commit got lost or if I hallucinated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work to make this branch mergable is tracked in #221
This is the PR to track the diff between the temporary
v3.xbranch anddevelop.All changes in this branch are related to the refactor to split out parsing/interpreting from
WebGLPreviewand introducingJobandPathprimitives.This refactor had to be done incrementally because it affected most current features. Each PR addresses a specific feature to bring it to the closest state possible to the v2 behavior.
The only feature that was scoped out is the highlight of the last layer and segment.