Skip to content

Conversation

remcoder
Copy link
Member

@remcoder remcoder commented Jun 24, 2025

This PR improves the build volume as follows:

  • a small grid option was added to optionally render a grid with squares of 1mm
  • the small grid can be toggled on or off
  • all build volume options now render separately from the gcode rendering, making such changes instantaneous
  • turning the build volume completely off has been fixed

Under the surface some non-trivial changes were needed. To separate the rendering of the build volume from the gcode rendering, parts of the create/dispose 'lifecycle', were rewritten as some camera/control logic and the use of groups in the scene:

  • the initScene method no longer initializes the buildVolume. The build volume is created once in the constructor and after that it handles itself via getters/setters.
  • the build volume and gcode are now better organized in separate groups in the scene.
  • all objects in the scene are now consistently positioned off of the threejs origin. Before they were centered via offsetting by x/2 and z/2. The new scheme is more consistent and obvious in hindsight. Only the camera and the controls are targeted at the center of the build plate. As a result there is no recentering anymore when the build volume changes size and model stays fixed.

improvements considered for this PR:

@remcoder remcoder requested a review from Copilot June 24, 2025 22:14
Copy link

github-actions bot commented Jun 24, 2025

Visit the preview URL for this PR (updated for commit 217edde):

https://gcode-preview--pr297-feature-scene-refact-vrjeg6o6.web.app

(expires Sat, 26 Jul 2025 19:59:16 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 59bd114ae4847b32c2bba0b68620b9069a3e3531

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors how the build volume is handled and rendered in the scene by separating it from the G-code rendering. Key changes include:

  • Refactoring the build volume construction to use getters/setters and a dedicated lifecycle in both WebGLPreview and BuildVolume.
  • Adjustments to helper classes (Grid, LineBox) and updates to tests, demos, and configuration to support a new small grid option.
  • Minor updates to dependencies and UI elements to improve consistency across the codebase.

Reviewed Changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/webgl-preview.ts Refactored buildVolume property and scene initialization to use a new BuildVolume pattern
src/helpers/line-box.ts Simplified geometry creation and clarified material initialization in the LineBox helper
src/helpers/grid.ts Updated grid generation logic to use non-centered coordinates and a rotated grid
src/dev-gui.ts Removed unused whitespace to streamline the dev GUI controls
src/build-volume.ts Refactored BuildVolume to use getters/setters, improved disposal, and added smallGrid support
src/tests/build-volume.ts Updated tests to reflect the new BuildVolume API and scene dependency requirements
package.json Upgraded the three dependency from 0.176.0 to 0.177.0
demo/js/default-settings.js Enhanced default settings to include the smallGrid property
demo/js/app.js Adjusted buildVolume update logic in watchers to handle the new smallGrid property
demo/index.html Added draggable="false" to the thumbnail and inserted UI controls for small grid toggling
Comments suppressed due to low confidence (2)

src/build-volume.ts:11

  • The public 'color' property was removed in favor of using internal gridColor and smallGridColor, but the tests still refer to the 'color' property. Update tests and documentation to reflect these API changes.
  private _x: number;

src/helpers/grid.ts:12

  • The grid helper now generates grid lines using coordinates starting at 0 rather than centering them. Verify that this change aligns with the intended scene positioning to maintain consistency with other scene objects.
    for (let z = 0; z <= sizeZ; z += stepZ) {


this.controls = new OrbitControls(this.camera, this.renderer.domElement);

this.controls.target.set(this._buildVolume.x / 2, 0, -this._buildVolume.y / 2);
Copy link

Copilot AI Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The controls target is set using properties of this._buildVolume without a prior null check. Consider adding a safeguard to ensure _buildVolume is defined to avoid potential runtime errors.

Suggested change
this.controls.target.set(this._buildVolume.x / 2, 0, -this._buildVolume.y / 2);
if (this._buildVolume) {
this.controls.target.set(this._buildVolume.x / 2, 0, -this._buildVolume.y / 2);
} else {
console.error('Build volume is not defined. Unable to set controls target.');
}

Copilot uses AI. Check for mistakes.

onMounted(async () => {
await selectPreset(defaultPreset);

watchEffect(() => {
Copy link

Copilot AI Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The buildVolume update logic is split across multiple watchEffect callbacks. Consolidating the conditions into a single cohesive block may improve readability and reduce the risk of inconsistent state updates.

Copilot uses AI. Check for mistakes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is actually to separate out different sets of changes due to side effects (like kicking of an animation)

const disposable = this.disposables.pop();
if (disposable) disposable.dispose();
// Recursively remove all children from the main group and their descendants from the scene
const removeRecursively = (object: Group) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@remcoder remcoder merged commit 2d39dd5 into develop Jun 26, 2025
3 checks passed
@remcoder remcoder deleted the feature/scene-refactor branch June 26, 2025 20:10
remcoder added a commit that referenced this pull request Jul 25, 2025
commit 0165cba
Author: Remco Veldkamp <[email protected]>
Date:   Fri Jul 25 17:15:32 2025 +0200

    Bump version to 3.0.0-alpha.4

commit f559ea9
Merge: a3dcb15 84785dd
Author: Remco Veldkamp <[email protected]>
Date:   Mon Jul 21 21:57:11 2025 +0200

    Merge pull request #306 from xyz-tools/fix/layer-logic

    Update layer logic

commit a3dcb15
Author: Remco Veldkamp <[email protected]>
Date:   Mon Jul 21 21:37:20 2025 +0200

    Fix bounding box not showing in example

commit 84785dd
Author: Remco Veldkamp <[email protected]>
Date:   Mon Jul 21 21:18:15 2025 +0200

    Put the min clipping plane below the layer

commit 1032c06
Author: Remco Veldkamp <[email protected]>
Date:   Mon Jul 21 20:55:54 2025 +0200

    update npm scripts

commit 345edd0
Author: Remco Veldkamp <[email protected]>
Date:   Mon Jul 21 20:30:36 2025 +0200

    Update test

commit 78af0e2
Author: Remco Veldkamp <[email protected]>
Date:   Mon Jul 21 20:29:58 2025 +0200

    Align test code with desc

commit 82e2238
Author: Remco Veldkamp <[email protected]>
Date:   Mon Jul 21 20:21:54 2025 +0200

    Remove duplicate test

commit d64c767
Author: Remco Veldkamp <[email protected]>
Date:   Mon Jul 21 20:07:34 2025 +0200

    Rename NonPlanarPathError to NonPlanarExtrusionError

commit e32a317
Author: Remco Veldkamp <[email protected]>
Date:   Mon Jul 21 18:40:29 2025 +0200

    Formatting

commit 800b3a9
Merge: 161c56d b3af69b
Author: Remco Veldkamp <[email protected]>
Date:   Mon Jul 21 18:38:23 2025 +0200

    Merge branch 'develop' into fix/layer-logic

commit b3af69b
Merge: 737befe 02dd0ac
Author: Remco Veldkamp <[email protected]>
Date:   Mon Jul 21 18:38:04 2025 +0200

    Merge pull request #304 from xyz-tools/fix/302

    Fix clipping plane initialization

commit 161c56d
Author: Remco Veldkamp <[email protected]>
Date:   Mon Jul 21 18:34:02 2025 +0200

    Tweak error case

commit 1941740
Author: Remco Veldkamp <[email protected]>
Date:   Mon Jul 21 18:33:49 2025 +0200

    gcodes before the first extrusion aren't indexed in a layer

commit 62ac599
Author: Remco Veldkamp <[email protected]>
Date:   Mon Jul 21 17:11:44 2025 +0200

    Remove (incorrect) linenumber

commit caa65f6
Author: Remco Veldkamp <[email protected]>
Date:   Mon Jul 21 17:04:21 2025 +0200

    Use concise format

commit 8c2efa2
Author: Remco Veldkamp <[email protected]>
Date:   Mon Jul 21 17:04:03 2025 +0200

    Update layer z value

commit 2ff4a73
Author: Remco Veldkamp <[email protected]>
Date:   Mon Jul 21 16:35:22 2025 +0200

    Tweak layer logic

commit 02dd0ac
Author: Remco Veldkamp <[email protected]>
Date:   Mon Jul 21 14:24:17 2025 +0200

    Cleanup

commit fcd7005
Author: Remco Veldkamp <[email protected]>
Date:   Mon Jul 21 14:14:43 2025 +0200

    Disable layer clipping if no layers detected

commit 9ea7603
Author: Remco Veldkamp <[email protected]>
Date:   Mon Jul 21 13:50:32 2025 +0200

    linting

commit 04d3982
Merge: 1bd1edc 737befe
Author: Remco Veldkamp <[email protected]>
Date:   Mon Jul 21 13:48:36 2025 +0200

    Merge branch 'develop' into fix/302

    # Conflicts:
    #	src/webgl-preview.ts

commit 737befe
Merge: 8d76e9d 6e261a5
Author: Remco Veldkamp <[email protected]>
Date:   Fri Jul 18 12:56:58 2025 +0200

    Merge pull request #305 from xyz-tools/dependabot/npm_and_yarn/multi-1083d179d6

    Bump on-headers and morgan

commit 6e261a5
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Thu Jul 17 21:25:24 2025 +0000

    Bump on-headers and morgan

    Bumps [on-headers](https://github.com/jshttp/on-headers) and [morgan](https://github.com/expressjs/morgan). These dependencies needed to be updated together.

    Updates `on-headers` from 1.0.2 to 1.1.0
    - [Release notes](https://github.com/jshttp/on-headers/releases)
    - [Changelog](https://github.com/jshttp/on-headers/blob/master/HISTORY.md)
    - [Commits](jshttp/on-headers@v1.0.2...v1.1.0)

    Updates `morgan` from 1.10.0 to 1.10.1
    - [Release notes](https://github.com/expressjs/morgan/releases)
    - [Changelog](https://github.com/expressjs/morgan/blob/master/HISTORY.md)
    - [Commits](expressjs/morgan@1.10.0...1.10.1)

    ---
    updated-dependencies:
    - dependency-name: on-headers
      dependency-version: 1.1.0
      dependency-type: indirect
    - dependency-name: morgan
      dependency-version: 1.10.1
      dependency-type: indirect
    ...

    Signed-off-by: dependabot[bot] <[email protected]>

commit 8d76e9d
Merge: 68bd0a8 32baadd
Author: Remco Veldkamp <[email protected]>
Date:   Wed Jul 9 21:18:14 2025 +0200

    Merge pull request #303 from TimTheBig/develop

    Update deps

commit 32baadd
Merge: a1e1d35 68bd0a8
Author: Remco Veldkamp <[email protected]>
Date:   Wed Jul 9 16:58:40 2025 +0200

    Merge branch 'develop' into develop

commit 68bd0a8
Author: Remco Veldkamp <[email protected]>
Date:   Wed Jul 9 16:57:45 2025 +0200

    Linting

commit a1e1d35
Author: TimTheBig <[email protected]>
Date:   Wed Jul 9 10:18:29 2025 -0400

    Format code

commit 28c6838
Author: TimTheBig <[email protected]>
Date:   Tue Jul 8 11:00:02 2025 -0400

    Use eslint 8 and live-server 1.2.1

commit 1ce4507
Author: TimTheBig <[email protected]>
Date:   Tue Jul 8 10:21:40 2025 -0400

    Update package-lock.json

commit 1bd1edc
Author: Remco Veldkamp <[email protected]>
Date:   Mon Jul 7 21:42:49 2025 +0200

    wip

commit e973850
Author: TimTheBig <[email protected]>
Date:   Mon Jul 7 10:11:04 2025 -0400

    Update deps

commit 3eca5c5
Merge: 2d39dd5 0343850
Author: Remco Veldkamp <[email protected]>
Date:   Tue Jul 1 12:03:03 2025 +0200

    Merge pull request #301 from xyz-tools/fix/issue-300

    Fix issue where setting an invalid build volume value throws an error

commit 0343850
Author: Remco Veldkamp <[email protected]>
Date:   Tue Jul 1 11:58:49 2025 +0200

    Formatting

commit b06f450
Author: Remco Veldkamp <[email protected]>
Date:   Tue Jul 1 11:58:24 2025 +0200

    Cleanup logs

commit 219787d
Author: Remco Veldkamp <[email protected]>
Date:   Tue Jul 1 11:58:16 2025 +0200

    Handle non-valid build volume values without throwing

commit 2d39dd5
Merge: 70ce9c6 217edde
Author: Remco Veldkamp <[email protected]>
Date:   Thu Jun 26 22:10:02 2025 +0200

    Merge pull request #297 from xyz-tools/feature/scene-refactor

    Scene/build volume refactor

commit 217edde
Merge: 0fabcd7 70ce9c6
Author: Remco Veldkamp <[email protected]>
Date:   Thu Jun 26 21:58:24 2025 +0200

    Merge branch 'develop' into feature/scene-refactor

commit 70ce9c6
Author: Remco Veldkamp <[email protected]>
Date:   Thu Jun 26 21:45:44 2025 +0200

    By default render progressive again

commit 5b55286
Author: Remco Veldkamp <[email protected]>
Date:   Thu Jun 26 21:42:46 2025 +0200

    Don't lint minified files

commit 9b42c7b
Author: Remco Veldkamp <[email protected]>
Date:   Thu Jun 26 21:35:40 2025 +0200

    Reduce loading times by using minimized libs

commit f5cc8f3
Author: Remco Veldkamp <[email protected]>
Date:   Thu Jun 26 21:17:54 2025 +0200

    Update vuejs to 3.5.17

commit 0fabcd7
Author: Remco Veldkamp <[email protected]>
Date:   Thu Jun 26 21:09:49 2025 +0200

    Fix imports and filename

commit 8c0b793
Author: Remco Veldkamp <[email protected]>
Date:   Thu Jun 26 21:05:49 2025 +0200

    Formatting

commit ae98c0f
Author: Remco Veldkamp <[email protected]>
Date:   Thu Jun 26 21:04:17 2025 +0200

    Cleanup logs

commit e0593b9
Author: Remco Veldkamp <[email protected]>
Date:   Thu Jun 26 21:03:34 2025 +0200

    Fix typing issue

commit 32ba722
Author: Remco Veldkamp <[email protected]>
Date:   Thu Jun 26 21:03:19 2025 +0200

    Update types

commit c5ae173
Author: Remco Veldkamp <[email protected]>
Date:   Thu Jun 26 20:44:26 2025 +0200

    Set defaults

commit 1bc22a5
Author: Remco Veldkamp <[email protected]>
Date:   Thu Jun 26 20:36:36 2025 +0200

    Add color picker for bounding box

commit 506f537
Author: Remco Veldkamp <[email protected]>
Date:   Thu Jun 26 20:36:05 2025 +0200

    Simplify bounding box rendering

commit db0969f
Author: Remco Veldkamp <[email protected]>
Date:   Thu Jun 26 20:01:39 2025 +0200

    Cleanup

commit a98bcd6
Author: Remco Veldkamp <[email protected]>
Date:   Thu Jun 26 19:59:24 2025 +0200

    Toggle bounding box

commit 2e4d1ff
Merge: 9468697 6d87d32
Author: Remco Veldkamp <[email protected]>
Date:   Thu Jun 26 17:07:04 2025 +0200

    Merge branch 'develop' into feature/scene-refactor

    # Conflicts:
    #	demo/js/app.js

commit 6d87d32
Author: Remco Veldkamp <[email protected]>
Date:   Thu Jun 26 17:06:28 2025 +0200

    Toggle progressive loading

commit 9468697
Author: Remco Veldkamp <[email protected]>
Date:   Thu Jun 26 16:50:54 2025 +0200

    Fix handling scene groups

commit 1709d07
Author: Remco Veldkamp <[email protected]>
Date:   Thu Jun 26 16:49:23 2025 +0200

    Change build volume through lil gui in steps of 10mm

commit 6690ba5
Author: Remco Veldkamp <[email protected]>
Date:   Thu Jun 26 16:48:56 2025 +0200

    Don't do a full render when changing the build volume through lil gui

commit 9255a52
Author: Remco Veldkamp <[email protected]>
Date:   Thu Jun 26 14:52:23 2025 +0200

    Consistent naming

commit 9b6d3ad
Author: Remco Veldkamp <[email protected]>
Date:   Thu Jun 26 11:17:37 2025 +0200

    Fix imports and tests

commit 19d4ca6
Merge: b868661 5737668
Author: Remco Veldkamp <[email protected]>
Date:   Thu Jun 26 11:07:31 2025 +0200

    Merge branch 'feature/scene-refactor' of github.com:xyz-tools/gcode-preview into feature/scene-refactor

commit b868661
Merge: 4a6b0b2 d370d8d
Author: Remco Veldkamp <[email protected]>
Date:   Thu Jun 26 11:07:25 2025 +0200

    Add GCodeVector3 for convenience

commit a854fac
Author: Remco Veldkamp <[email protected]>
Date:   Thu Jun 26 10:49:25 2025 +0200

    Add dispose button to dev helpers

commit d370d8d
Author: Remco Veldkamp <[email protected]>
Date:   Thu Jun 26 09:48:01 2025 +0200

    wip2

commit c95afba
Author: Remco Veldkamp <[email protected]>
Date:   Thu Jun 26 09:47:42 2025 +0200

    wip

commit 5737668
Merge: 4a6b0b2 9e9236a
Author: Remco Veldkamp <[email protected]>
Date:   Wed Jun 25 13:37:07 2025 +0200

    Merge branch 'develop' into feature/scene-refactor

commit 4a6b0b2
Author: Remco Veldkamp <[email protected]>
Date:   Wed Jun 25 12:16:14 2025 +0200

    Formatting

commit 4443adf
Author: Remco Veldkamp <[email protected]>
Date:   Wed Jun 25 12:14:59 2025 +0200

    Fix bounding box position

commit 9e9236a
Author: Remco Veldkamp <[email protected]>
Date:   Wed Jun 25 11:09:57 2025 +0200

    Formatting

commit b59656a
Merge: baedd00 e55f570
Author: Remco Veldkamp <[email protected]>
Date:   Wed Jun 25 11:08:31 2025 +0200

    Merge branch 'develop' into feature/scene-refactor

commit baedd00
Author: Remco Veldkamp <[email protected]>
Date:   Wed Jun 25 11:08:15 2025 +0200

    Turn on small grid in arcs example

commit 9ae183e
Author: Remco Veldkamp <[email protected]>
Date:   Wed Jun 25 11:00:17 2025 +0200

    Cleanup

commit e55f570
Author: Remco Veldkamp <[email protected]>
Date:   Wed Jun 25 11:00:47 2025 +0200

    Add dev button to clear the stored camera settings

commit c5f0a62
Author: Remco Veldkamp <[email protected]>
Date:   Wed Jun 25 10:55:48 2025 +0200

    Prevent multiple scene updates

commit 6df7805
Author: Remco Veldkamp <[email protected]>
Date:   Tue Jun 24 23:48:09 2025 +0200

    Cleanup

commit ba75afb
Author: Remco Veldkamp <[email protected]>
Date:   Tue Jun 24 23:46:31 2025 +0200

    Recursively clear the scene hierarchy

commit 6a3ac93
Author: Remco Veldkamp <[email protected]>
Date:   Tue Jun 24 23:45:44 2025 +0200

    Fix toggling the build volume on/off

commit 7c19e77
Author: Remco Veldkamp <[email protected]>
Date:   Tue Jun 24 22:59:31 2025 +0200

    Add batched meshes to chunk group

commit d19897c
Author: Remco Veldkamp <[email protected]>
Date:   Tue Jun 24 22:59:10 2025 +0200

    Fix updating small grid setting

commit fa9e423
Author: Remco Veldkamp <[email protected]>
Date:   Tue Jun 24 22:18:16 2025 +0200

    wip

    # Conflicts:
    #	src/webgl-preview.ts

commit 3842503
Author: Remco Veldkamp <[email protected]>
Date:   Tue Jun 24 22:13:59 2025 +0200

    Cleanup

commit 28899d4
Author: Remco Veldkamp <[email protected]>
Date:   Tue Jun 24 21:49:12 2025 +0200

    Prevent thumbnail from being dragged accidentally

commit b19f2a3
Author: Remco Veldkamp <[email protected]>
Date:   Tue Jun 24 21:48:52 2025 +0200

    Fix tests

commit a64e598
Author: Remco Veldkamp <[email protected]>
Date:   Tue Jun 24 21:48:40 2025 +0200

    Fix model position

commit 1f4093a
Author: Remco Veldkamp <[email protected]>
Date:   Tue Jun 24 21:41:30 2025 +0200

    Cleanup

commit 6e3febe
Author: Remco Veldkamp <[email protected]>
Date:   Tue Jun 24 21:30:27 2025 +0200

    wip

commit 8717452
Author: Remco Veldkamp <[email protected]>
Date:   Tue Jun 24 18:42:35 2025 +0200

    Save/load camera settings

commit 8e6cf1d
Author: Remco Veldkamp <[email protected]>
Date:   Tue Jun 24 18:36:16 2025 +0200

    Fix generating extra bogus groups due to fractional indices

commit 9b21e8d
Author: Remco Veldkamp <[email protected]>
Date:   Tue Jun 24 18:26:37 2025 +0200

    Reduce frustum near limit

commit 6343ade
Merge: 17a4747 0dc4e0c
Author: Remco Veldkamp <[email protected]>
Date:   Tue May 27 19:50:50 2025 +0200

    Merge pull request #296 from xyz-tools/feature/dispose-lilgui-stats

    Dispose lil-gui and stats

commit 0dc4e0c
Merge: 415e2b0 17a4747
Author: Remco Veldkamp <[email protected]>
Date:   Tue May 27 19:50:32 2025 +0200

    Merge branch 'develop' into feature/dispose-lilgui-stats

commit 17a4747
Author: Remco Veldkamp <[email protected]>
Date:   Tue May 27 19:45:47 2025 +0200

    Remove wireframe option for now

commit 415e2b0
Author: Remco Veldkamp <[email protected]>
Date:   Tue May 27 17:51:37 2025 +0200

    linting

commit 2c35b07
Author: Remco Veldkamp <[email protected]>
Date:   Tue May 27 17:43:02 2025 +0200

    Dispose lil-gui and stats

commit 3a88b89
Author: Remco Veldkamp <[email protected]>
Date:   Tue May 27 16:13:25 2025 +0200

    Track extrusion distance total E

commit ec1b860
Author: Remco Veldkamp <[email protected]>
Date:   Sun May 25 20:26:58 2025 +0200

    Update lineWidth

commit a06351c
Merge: e048d0a 088e23e
Author: Remco Veldkamp <[email protected]>
Date:   Sun May 25 21:26:50 2025 +0200

    Merge pull request #269 from xyz-tools/fix/webggl-errors

    Skip non-moving g0/g1 commands

commit 088e23e
Author: Remco Veldkamp <[email protected]>
Date:   Sun May 25 21:23:44 2025 +0200

    Linting

commit f9bc6c7
Author: Remco Veldkamp <[email protected]>
Date:   Sun May 25 21:16:04 2025 +0200

    Tweak debug logs

commit ab042ca
Author: Remco Veldkamp <[email protected]>
Date:   Sun May 25 21:11:41 2025 +0200

    Remove check that wasn't really needed

commit aa68469
Author: Remco Veldkamp <[email protected]>
Date:   Sun May 25 20:59:45 2025 +0200

    Less spammy debug logs

commit f5daf5b
Author: Remco Veldkamp <[email protected]>
Date:   Sun May 25 20:52:04 2025 +0200

    Use 'deretraction' for E>0 non-move commands

commit ee3a692
Author: Remco Veldkamp <[email protected]>
Date:   Sun May 25 20:48:14 2025 +0200

    Linting

commit 67a5550
Author: Remco Veldkamp <[email protected]>
Date:   Sun May 25 20:47:20 2025 +0200

    Fix test conditions

commit 3ea3574
Author: Remco Veldkamp <[email protected]>
Date:   Sun May 25 20:46:13 2025 +0200

    Use constants

commit b535b99
Merge: 38c8d47 e048d0a
Author: Remco Veldkamp <[email protected]>
Date:   Sun May 25 20:04:57 2025 +0200

    Merge branch 'develop' into fix/webggl-errors

commit e048d0a
Merge: aeb09a5 254c7aa
Author: Remco Veldkamp <[email protected]>
Date:   Sun May 25 19:38:59 2025 +0200

    Merge pull request #287 from xyz-tools/fix/legacy-batched-mesh

    Support webgl 1

commit 254c7aa
Merge: 342a9d8 aeb09a5
Author: Remco Veldkamp <[email protected]>
Date:   Sun May 25 19:33:08 2025 +0200

    Merge branch 'develop' into fix/legacy-batched-mesh

commit 342a9d8
Author: Remco Veldkamp <[email protected]>
Date:   Sun May 25 19:32:44 2025 +0200

    Revert "Downgrade to three r162 for testing"

    This reverts commit de8815d.

commit aeee18d
Author: Remco Veldkamp <[email protected]>
Date:   Sun May 25 19:32:07 2025 +0200

    Add comment

commit aeb09a5
Author: Remco Veldkamp <[email protected]>
Date:   Sun May 25 19:25:24 2025 +0200

    Also update threejs types

commit 97a9d30
Author: Remco Veldkamp <[email protected]>
Date:   Sun May 25 19:11:51 2025 +0200

    Bump deps

commit cf035ce
Merge: 45c51a0 5a6a086
Author: Remco Veldkamp <[email protected]>
Date:   Sun May 25 18:55:39 2025 +0200

    Merge pull request #292 from xyz-tools/feature/render-bounding-box

    Render bounding box

commit 5a6a086
Merge: 2e73de2 45c51a0
Author: Remco Veldkamp <[email protected]>
Date:   Sun May 25 18:50:54 2025 +0200

    Merge branch 'develop' into feature/render-bounding-box

    # Conflicts:
    #	src/job.ts

commit 45c51a0
Merge: 5c71ada 7b1b95b
Author: Remco Veldkamp <[email protected]>
Date:   Sun May 25 18:43:30 2025 +0200

    Merge pull request #295 from xyz-tools/feature/handle-stream

    Handle stream via processGCode

commit 7b1b95b
Merge: 04b21c0 5c71ada
Author: Remco Veldkamp <[email protected]>
Date:   Sun May 25 18:40:42 2025 +0200

    Merge branch 'develop' into feature/handle-stream

commit 5c71ada
Author: Remco Veldkamp <[email protected]>
Date:   Sun May 25 11:10:17 2025 +0200

    Update legal

commit 04b21c0
Merge: f5f3e91 425922a
Author: Remco Veldkamp <[email protected]>
Date:   Sun May 25 18:39:33 2025 +0200

    Merge branch 'develop' into feature/handle-stream

commit f5f3e91
Author: Remco Veldkamp <[email protected]>
Date:   Sun May 25 18:37:29 2025 +0200

    Remove redundant logging

commit cee64d3
Author: Remco Veldkamp <[email protected]>
Date:   Sun May 25 18:31:47 2025 +0200

    linting

commit aca7a59
Author: Remco Veldkamp <[email protected]>
Date:   Sun May 25 18:29:08 2025 +0200

    ProcessGCode handles streams

commit cbab810
Author: Remco Veldkamp <[email protected]>
Date:   Sun May 25 15:53:07 2025 +0200

    Move readFromStream back into main

commit 38c8d47
Merge: 04479a8 425922a
Author: Remco Veldkamp <[email protected]>
Date:   Sun May 25 15:34:30 2025 +0200

    Merge branch 'develop' into fix/webggl-errors

commit a9520e5
Merge: ff77bce 425922a
Author: Remco Veldkamp <[email protected]>
Date:   Sun May 25 15:33:25 2025 +0200

    Merge branch 'develop' into fix/legacy-batched-mesh

commit 2e73de2
Merge: dfa2dba 425922a
Author: Remco Veldkamp <[email protected]>
Date:   Sun May 25 15:33:13 2025 +0200

    Merge branch 'develop' into feature/render-bounding-box

commit 425922a
Merge: f36aa19 e31f61c
Author: Remco Veldkamp <[email protected]>
Date:   Sun May 25 15:32:44 2025 +0200

    Merge pull request #284 from xyz-tools/feature/undeprecate-dnd

    Undeprecate dnd and move to dom-utils

commit e31f61c
Author: Remco Veldkamp <[email protected]>
Date:   Sun May 25 15:22:21 2025 +0200

    linting

commit 7ecf055
Author: Remco Veldkamp <[email protected]>
Date:   Sun May 25 15:16:41 2025 +0200

    More cleanup

commit 96ac51c
Author: Remco Veldkamp <[email protected]>
Date:   Sun May 25 15:16:30 2025 +0200

    Sensible default for rendering paths per frame

commit 5a336e7
Author: Remco Veldkamp <[email protected]>
Date:   Sun May 25 15:15:15 2025 +0200

    Restore progessive render on drop

commit a2448f8
Author: Remco Veldkamp <[email protected]>
Date:   Sun May 25 15:01:10 2025 +0200

    Cleanup

commit eba64e6
Author: Remco Veldkamp <[email protected]>
Date:   Sun May 25 13:55:30 2025 +0200

    Update UI after drop

commit cf2bb64
Author: Remco Veldkamp <[email protected]>
Date:   Sun May 25 12:56:25 2025 +0200

    Break loop when the stream has ended

commit 4589a0c
Author: Remco Veldkamp <[email protected]>
Date:   Sun May 25 12:54:58 2025 +0200

    Remove redundant render call

commit 238ddc0
Author: Remco Veldkamp <[email protected]>
Date:   Sun May 25 12:53:55 2025 +0200

    Reset end layer

commit 01c4853
Author: Remco Veldkamp <[email protected]>
Date:   Sun May 25 12:51:00 2025 +0200

    Fix rendering

commit b6cb17e
Merge: ec067a7 f36aa19
Author: Remco Veldkamp <[email protected]>
Date:   Sun May 25 10:43:18 2025 +0200

    Merge branch 'develop' into feature/undeprecate-dnd

commit dfa2dba
Merge: c0e0646 f36aa19
Author: Remco Veldkamp <[email protected]>
Date:   Sun May 25 10:40:49 2025 +0200

    Merge branch 'develop' into feature/render-bounding-box

commit f36aa19
Merge: 91ba62e dcabddc
Author: Remco Veldkamp <[email protected]>
Date:   Sat May 24 17:37:37 2025 +0200

    Merge pull request #294 from xyz-tools/feature/bringing-back-benchy

    Add 3DBenchy with metadata

commit dcabddc
Author: Remco Veldkamp <[email protected]>
Date:   Sat May 24 17:30:47 2025 +0200

    Add 3DBenchy with metadata

commit c0e0646
Author: Remco Veldkamp <[email protected]>
Date:   Thu May 22 09:22:17 2025 +0200

    Linting

commit 3cc4104
Author: Remco Veldkamp <[email protected]>
Date:   Thu May 22 09:10:18 2025 +0200

    Fix index error handling

commit e5c7be8
Author: Remco Veldkamp <[email protected]>
Date:   Thu May 22 08:57:30 2025 +0200

    Update test to fix imports

commit 958da38
Author: Remco Veldkamp <[email protected]>
Date:   Wed May 21 22:33:13 2025 +0200

    Add example

commit a7df789
Author: Remco Veldkamp <[email protected]>
Date:   Wed May 21 22:16:59 2025 +0200

    Public api for configuring bounding box color

commit 901d500
Author: Remco Veldkamp <[email protected]>
Date:   Wed May 21 19:52:25 2025 +0200

    Render bounding box

commit 91ba62e
Merge: bd86ba8 ffdd4b2
Author: Remco Veldkamp <[email protected]>
Date:   Wed May 21 11:01:40 2025 +0200

    Merge pull request #291 from xyz-tools/dependabot/npm_and_yarn/multi-0faedc2458

    Bump esbuild and vitest

commit ffdd4b2
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Wed May 21 08:55:22 2025 +0000

    Bump esbuild and vitest

    Bumps [esbuild](https://github.com/evanw/esbuild) to 0.25.4 and updates ancestor dependency [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest). These dependencies need to be updated together.

    Updates `esbuild` from 0.21.5 to 0.25.4
    - [Release notes](https://github.com/evanw/esbuild/releases)
    - [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG-2024.md)
    - [Commits](evanw/esbuild@v0.21.5...v0.25.4)

    Updates `vitest` from 1.6.0 to 3.1.4
    - [Release notes](https://github.com/vitest-dev/vitest/releases)
    - [Commits](https://github.com/vitest-dev/vitest/commits/v3.1.4/packages/vitest)

    ---
    updated-dependencies:
    - dependency-name: esbuild
      dependency-version: 0.25.4
      dependency-type: indirect
    - dependency-name: vitest
      dependency-version: 3.1.4
      dependency-type: direct:development
    ...

    Signed-off-by: dependabot[bot] <[email protected]>

commit bd86ba8
Merge: 40b7623 250c4c1
Author: Remco Veldkamp <[email protected]>
Date:   Wed May 21 10:54:03 2025 +0200

    Merge pull request #290 from xyz-tools/dependabot/npm_and_yarn/vite-5.4.19

    Bump vite from 5.4.14 to 5.4.19

commit 250c4c1
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Wed May 21 07:16:55 2025 +0000

    Bump vite from 5.4.14 to 5.4.19

    Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.4.14 to 5.4.19.
    - [Release notes](https://github.com/vitejs/vite/releases)
    - [Changelog](https://github.com/vitejs/vite/blob/v5.4.19/packages/vite/CHANGELOG.md)
    - [Commits](https://github.com/vitejs/vite/commits/v5.4.19/packages/vite)

    ---
    updated-dependencies:
    - dependency-name: vite
      dependency-version: 5.4.19
      dependency-type: indirect
    ...

    Signed-off-by: dependabot[bot] <[email protected]>

commit 40b7623
Author: Remco Veldkamp <[email protected]>
Date:   Wed May 7 21:52:45 2025 +0200

    Add logging

    Remove unnecessary logging

commit ff77bce
Author: Remco Veldkamp <[email protected]>
Date:   Mon Feb 17 13:22:41 2025 +0100

    Make use of addInstance optional for older three versions

commit de8815d
Author: Remco Veldkamp <[email protected]>
Date:   Mon Feb 17 13:22:12 2025 +0100

    Downgrade to three r162 for testing

commit ec067a7
Author: Remco Veldkamp <[email protected]>
Date:   Tue Jan 28 20:51:43 2025 +0100

    Remove old (and not working) stream examples

commit 357fbc7
Author: Remco Veldkamp <[email protected]>
Date:   Tue Jan 28 20:28:40 2025 +0100

    Remove deprecation warning

commit afe0e4f
Author: Remco Veldkamp <[email protected]>
Date:   Tue Jan 28 00:13:05 2025 +0100

    Temporary? disable the drop handler in the demo and use the lib

commit 178d515
Author: Remco Veldkamp <[email protected]>
Date:   Tue Jan 28 00:07:01 2025 +0100

    Fix instance

commit f36e5ad
Author: Remco Veldkamp <[email protected]>
Date:   Tue Jan 28 00:01:58 2025 +0100

    Undeprecate dnd and move to dom-utils

commit 04479a8
Author: Remco Veldkamp <[email protected]>
Date:   Mon Jan 27 22:22:40 2025 +0100

    Cleanup

commit d6081c4
Author: Remco Veldkamp <[email protected]>
Date:   Tue Jan 14 23:04:24 2025 +0100

    Linting

commit a381473
Author: Remco Veldkamp <[email protected]>
Date:   Mon Dec 30 00:06:35 2024 +0100

    Add a parser test for E values without a leading 0

commit 2f75f85
Author: Remco Veldkamp <[email protected]>
Date:   Mon Dec 30 00:04:22 2024 +0100

    Update tests

commit 73faea3
Author: Remco Veldkamp <[email protected]>
Date:   Mon Dec 30 00:01:57 2024 +0100

    Add note

commit 03b6b5f
Author: Remco Veldkamp <[email protected]>
Date:   Mon Dec 30 00:00:28 2024 +0100

    Measure gcode execution time

commit c05f781
Author: Remco Veldkamp <[email protected]>
Date:   Sun Dec 29 23:59:22 2024 +0100

    Track non-moving move commands

commit 6659efd
Author: Remco Veldkamp <[email protected]>
Date:   Sun Dec 29 23:58:24 2024 +0100

    Skip moves that have no x, y or z

commit 0c042db
Author: Remco Veldkamp <[email protected]>
Date:   Sun Dec 29 23:55:03 2024 +0100

    Improve checking for zero-length path segments and don't allocate geometry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants