Skip to content

[READY] LSP: Allow globs in GetProjectRootFiles#1759

Merged
bstaletic merged 2 commits intoycm-core:masterfrom
bstaletic:glob_root_config
Aug 23, 2024
Merged

[READY] LSP: Allow globs in GetProjectRootFiles#1759
bstaletic merged 2 commits intoycm-core:masterfrom
bstaletic:glob_root_config

Conversation

@bstaletic
Copy link
Collaborator

@bstaletic bstaletic commented Aug 23, 2024

Some languages name the project description file after the root directory.
I.e. foo/foo.csproj and foo/foo.sln in case of C#.

This accommodates those language servers.

This is the last part needed for users to be able to use Omnisharp-Roslyn through GenericLanguageServer.
We should still get #1752 working, if for no other reason, then not to drag ancient omnisharp version.


This change is Reviewable

Some languages name the project description file after the root
directory.
I.e. `foo/foo.csproj` and `foo/foo.sln` in case of C#.

This accomodates those language servers.
@codecov
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.90%. Comparing base (779a711) to head (89ececb).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1759      +/-   ##
==========================================
- Coverage   95.94%   95.90%   -0.05%     
==========================================
  Files          84       84              
  Lines        8464     8465       +1     
  Branches      163      163              
==========================================
- Hits         8121     8118       -3     
- Misses        293      297       +4     
  Partials       50       50              

@bstaletic bstaletic merged commit 8b61f19 into ycm-core:master Aug 23, 2024
@bstaletic bstaletic deleted the glob_root_config branch August 23, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant