Rollback transaction fix #23628
Rollback transaction fix #23628
Conversation
|
🟢 |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
XJIE6
force-pushed
the
test_single_operation
branch
from
07bfa63 to
e49ba63
Compare
XJIE6
force-pushed
the
test_single_operation
branch
from
e49ba63 to
c985903
Compare
|
⚪
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
|
||
| if (!evWrite.Record.HasTxId() && | ||
| evWrite.Record.HasLocks() && | ||
| evWrite.Record.GetLocks().GetOp() == NKikimrDataEvents::TKqpLocks::Rollback && |
There was a problem hiding this comment.
Нужно возвращать ошибку, если пришёл abort без нужных атрибутов
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
XJIE6
force-pushed
the
test_single_operation
branch
from
583da99 to
35c647c
Compare
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| @@ -215,6 +215,19 @@ TWriteOperation::TPtr TOperationsManager::CreateWriteOperation(const TUnifiedPat | |||
| } | |||
|
|
|||
| TConclusion<EOperationBehaviour> TOperationsManager::GetBehaviour(const NEvents::TDataEvents::TEvWrite& evWrite) { | |||
| //FIXME #23784 | |||
| if (evWrite.Record.HasLocks() && evWrite.Record.GetLocks().GetOp() == NKikimrDataEvents::TKqpLocks::Rollback) { | |||
There was a problem hiding this comment.
Может быть Rollback без локов?
There was a problem hiding this comment.
Видимо нет, потому что Op лежит внутри Locks. Если нет Locks, то и нет Op
другими словами проверять HasLocks() нужно, чтобы справа сделать GetLocks()
| @@ -215,6 +215,19 @@ TWriteOperation::TPtr TOperationsManager::CreateWriteOperation(const TUnifiedPat | |||
| } | |||
|
|
|||
| TConclusion<EOperationBehaviour> TOperationsManager::GetBehaviour(const NEvents::TDataEvents::TEvWrite& evWrite) { | |||
| //FIXME #23784 | |||
| if (evWrite.Record.HasLocks() && evWrite.Record.GetLocks().GetOp() == NKikimrDataEvents::TKqpLocks::Rollback) { | |||
| // AFL_VERIFY_DEBUG(!evWrite.Record.HasTxId())("TxId", evWrite.Record.GetTxId()); | |||
There was a problem hiding this comment.
Я бы не группировал проверки, а добавлял по одной
// AFL_VERIFY_DEBUG(!evWrite.Record.HasTxId())("TxId", evWrite.Record.GetTxId());
// if (!evWrite.Record.HasTxId()) {
// return EOperationBehaviour::AbortWriteLock;
// }
--- другие проверки ---
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
...
Changelog category
Description for reviewers
Сейчас kqp может присылать Rollback как с TxId, так и без TxId. В новой версии kqp Rollback будет только без TxId.
Вот ишью на исправление в будущем #23784