Skip to content

Conversation

nshestakov
Copy link
Collaborator

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@nshestakov nshestakov requested a review from a team as a code owner August 27, 2025 13:43
@nshestakov nshestakov requested review from ubyte and Copilot and removed request for ubyte August 27, 2025 13:43
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the verification logic for the HasKinesisData flag by considering both PartitionKey and ExplicitHashKey fields instead of only checking PartitionKey.

  • Enhanced the condition to include ExplicitHashKey in the HasKinesisData flag determination

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

🟢 2025-08-27 13:45:10 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Aug 27, 2025

2025-08-27 13:45:23 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1025ed1 has started.
2025-08-27 13:45:37 UTC Artifacts will be uploaded here
2025-08-27 13:48:54 UTC ya make is running...
🟡 2025-08-27 15:15:23 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
37755 34991 0 3 2720 41

2025-08-27 15:18:49 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-08-27 15:34:10 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
537 (only retried tests) 509 0 0 0 28

🟢 2025-08-27 15:34:20 UTC Build successful.
🟡 2025-08-27 15:34:45 UTC ydbd size 2.3 GiB changed* by +156.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 2e26d9c merge: 1025ed1 diff diff %
ydbd size 2 433 990 176 Bytes 2 434 150 584 Bytes +156.6 KiB +0.007%
ydbd stripped size 509 848 200 Bytes 509 884 040 Bytes +35.0 KiB +0.007%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 27, 2025

2025-08-27 13:45:37 UTC Pre-commit check linux-x86_64-release-asan for 1025ed1 has started.
2025-08-27 13:45:53 UTC Artifacts will be uploaded here
2025-08-27 13:49:27 UTC ya make is running...
🟡 2025-08-27 15:58:30 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15128 14570 0 198 327 33

🟢 2025-08-27 15:59:54 UTC Build successful.
🟢 2025-08-27 16:00:28 UTC ydbd size 4.0 GiB changed* by -696 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: af247e9 merge: 1025ed1 diff diff %
ydbd size 4 277 593 752 Bytes 4 277 593 056 Bytes -696 Bytes -0.000%
ydbd stripped size 1 483 437 592 Bytes 1 483 437 720 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nshestakov nshestakov enabled auto-merge (squash) August 27, 2025 13:45
@nshestakov nshestakov merged commit f31fc37 into ydb-platform:main Aug 28, 2025
13 checks passed
@nshestakov nshestakov deleted the PQ-blob branch August 28, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants