Skip to content

Conversation

snaury
Copy link
Member

@snaury snaury commented Aug 27, 2025

Changelog entry

Fix process crashing with assertion when follower promotes to leader or reattaches while booting. Fixes #17469.

Changelog category

  • Bugfix

Description for reviewers

Ignore responses to requests from earlier boot attempts (which may not match later requests anyway), and ignore responses after the boot finishes.

@snaury snaury self-assigned this Aug 27, 2025
Copy link

github-actions bot commented Aug 27, 2025

2025-08-27 15:22:21 UTC Pre-commit check linux-x86_64-release-asan for 4cc6bfe has started.
2025-08-27 15:22:36 UTC Artifacts will be uploaded here
2025-08-27 15:25:55 UTC ya make is running...
2025-08-27 15:46:20 UTC Check cancelled

Copy link

github-actions bot commented Aug 27, 2025

2025-08-27 15:22:22 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4cc6bfe has started.
2025-08-27 15:22:36 UTC Artifacts will be uploaded here
2025-08-27 15:26:02 UTC ya make is running...
2025-08-27 15:46:16 UTC Check cancelled

Copy link

🟢 2025-08-27 15:27:49 UTC The validation of the Pull Request description is successful.

@snaury snaury force-pushed the fix-17469-unexpected-request-4 branch from 87b9c10 to 411e97a Compare August 27, 2025 15:45
@snaury snaury marked this pull request as ready for review August 27, 2025 15:46
@snaury snaury requested a review from a team as a code owner August 27, 2025 15:46
Copy link

github-actions bot commented Aug 27, 2025

2025-08-27 15:47:43 UTC Pre-commit check linux-x86_64-relwithdebinfo for 176f60c has started.
2025-08-27 15:47:56 UTC Artifacts will be uploaded here
2025-08-27 15:51:14 UTC ya make is running...
🟡 2025-08-27 17:24:08 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38056 35305 0 4 2713 34

2025-08-27 17:28:04 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-08-27 17:43:34 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
268 (only retried tests) 238 0 0 0 30

🟢 2025-08-27 17:43:42 UTC Build successful.
🟢 2025-08-27 17:44:06 UTC ydbd size 2.3 GiB changed* by +87.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 04d7c1c merge: 176f60c diff diff %
ydbd size 2 434 167 848 Bytes 2 434 257 264 Bytes +87.3 KiB +0.004%
ydbd stripped size 509 888 392 Bytes 509 908 488 Bytes +19.6 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 27, 2025

2025-08-27 15:50:32 UTC Pre-commit check linux-x86_64-release-asan for 176f60c has started.
2025-08-27 15:50:35 UTC Artifacts will be uploaded here
2025-08-27 15:53:54 UTC ya make is running...
🟡 2025-08-27 17:58:26 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15419 14955 0 111 320 33

🟢 2025-08-27 17:59:52 UTC Build successful.
🟡 2025-08-27 18:00:21 UTC ydbd size 4.0 GiB changed* by +158.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 04d7c1c merge: 176f60c diff diff %
ydbd size 4 277 622 568 Bytes 4 277 784 360 Bytes +158.0 KiB +0.004%
ydbd stripped size 1 483 448 600 Bytes 1 483 515 960 Bytes +65.8 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@snaury snaury merged commit 8d8088a into ydb-platform:main Aug 28, 2025
12 checks passed
@snaury snaury deleted the fix-17469-unexpected-request-4 branch August 28, 2025 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VERIFY failed: Unexpected request 4
2 participants