-
Notifications
You must be signed in to change notification settings - Fork 173
Add comprehensive tests for wildcard semantics in scalar package #1805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
5
commits into
master
Choose a base branch
from
copilot/fix-1630
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: yegor256 <[email protected]>
Copilot finished work on behalf of
yegor256
June 10, 2025 18:15
@copilot looks like you broke the build. Run |
…csTest Co-authored-by: yegor256 <[email protected]>
Copilot finished work on behalf of
yegor256
June 10, 2025 19:28
@copilot the build is broken, fix it. Remove comments from method bodies -- they are prohibited. |
Co-authored-by: yegor256 <[email protected]>
Copilot finished work on behalf of
yegor256
June 11, 2025 07:01
@copilot the build is still broken |
Co-authored-by: yegor256 <[email protected]>
Copilot finished work on behalf of
yegor256
June 11, 2025 10:03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the TODO puzzle in
package-info.java
by creating comprehensive tests for relaxed wildcards semantics in the scalar package classes.Changes Made
Added Tests (
WildcardSemanticsTest.java
)Created 10 focused tests that verify the proper behavior of Java wildcards (
? extends T
,? super T
) in key scalar classes:Covariance Tests (
? extends T
):ScalarOf
accepting covariant functions and scalarsMapped
accepting covariant scalarsAnd
/Or
accepting covariant iterablesFlattened
handling nested wildcards likeScalar<? extends Scalar<? extends X>>
ScalarWithFallback
accepting covariant scalarsContravariance Tests (
? super T
):ScalarOf
accepting contravariant processors and functionsMapped
accepting contravariant functionsAnd
/Or
accepting contravariant functionsRemoved TODO Puzzle
Cleaned up
package-info.java
by removing the completed TODO puzzle:Testing
All 10 new tests pass successfully, verifying that:
The tests demonstrate that the scalar classes properly support Java's wildcard semantics, ensuring type safety while allowing flexible usage patterns.
Fixes #1630.