Create feeder subsystem #115
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drew-beamer
requested changes
Sep 23, 2024
| } | ||
|
|
||
|
|
||
| private static class FeederSubsystem extends SubsystemBase { |
Member
There was a problem hiding this comment.
Can we break this out into its own file?
Member
There was a problem hiding this comment.
I don't really think of the two subsystems as the same thing. It's always been a bit confusing to me why we didn't split it off initially. I think having separate files would help with findability as well as general organization.
Comment on lines
95
to
97
| protected Command spinFeederAndStop(double speed) { | ||
| return startEnd(() -> feederMotor.set(speed), feederMotor::stopMotor); | ||
| } |
Member
There was a problem hiding this comment.
I think we can be more specific with the command(s) we define here. We're pretty much only ever going to have one intake and one eject. I'd handle the beam break logic within here. We can still publish this if we need it, but I'd rather have a more explicit interface here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent the use of one component of the shooter from stopping the use of the other