Skip to content

Conversation

@vidyuthdev
Copy link

@vidyuthdev vidyuthdev commented Jul 31, 2024

Work in Progress - Will finish by thursday. VAK

README finished - will continue to update

Work in Progress - Will finish by thursday. VAK
@vidyuthdev vidyuthdev requested a review from a team as a code owner July 31, 2024 00:49
Not final yet, will keep updating to ensure clarity and conciseness.
@qwertycloudhub qwertycloudhub linked an issue Aug 9, 2024 that may be closed by this pull request
1 task
Copy link
Member

@drew-beamer drew-beamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work so far! Just have some thoughts on areas we could have a bit more info/could be a bit more specific.

Comment on lines 5 to 9
1. Go to "https://www.jetbrains.com/products/compare/?product=idea&product=idea-ce"
2. Install "IntelliJ Community Edition"
3. Follow the instructions you will be prompted to
4. Open the application for the first time
5. Click the create project button and choose preferred folder location
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might just want to link to our docs for getting robot development set up for the first time:

https://wiki.yetirobotics.org/books/robot-software/page/getting-started-with-robot-development

Say something along the lines of "If this is your first time working with FRC code, follow our environment setup guide here: [link]"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, will do.

README.md Outdated
8. Finished!

Main points in this repository
1. Basic XML Documents
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't do a whole bunch with XML, we can probably remove references to it. Most of it is auto-generated, and we don't often need to look at those files.

Comment on lines 24 to 43
1. Commands(Auto and Pivot)
Aim
Handoff
Shooter
Turn

3. Constants - Exact values

4. Subsystems - Includes
Arm
Elevator
Intake
Pivot
Shooter
Vision

5. Utilities - Controller UTIL
Alliance
Limelight
ShooterState - Data
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to have descriptions here for what each of these classes accomplishes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're unsure, feel free to ask in #programming :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the all the feedback, I'll make sure to work on it :)

@qwertycloudhub qwertycloudhub added the tech debt Refactor or cleanup work label Aug 12, 2024
vidyuthdev and others added 4 commits August 13, 2024 18:45
Co-authored-by: Drew Beamer <[email protected]>
Co-authored-by: Drew Beamer <[email protected]>
Co-authored-by: Drew Beamer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tech debt Refactor or cleanup work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cleanup: Create a README

4 participants