better performance for exists() method of Query class #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ziaratban
commented
Dec 27, 2019
ziaratban
commented
| Q | A |
|---|---|
| Is bugfix? | yes |
| New feature? | no |
| Breaks BC? | no |
| Tests pass? | yes |
| Fixed issues | #290 |
samdark
reviewed
Dec 27, 2019
Merged
Contributor
Author
|
@samdark please set performance-query-exists to current PR. |
Member
|
@ziaratban what do you mean by "set performance-query-exists to current PR"? I can't change PR's branch. |
Contributor
Author
i removed commit from master branch and me create a new branch for this PR. because this commit show in all my PR. seems i must be create a new PR. thanks. |
Member
|
Yes. Start with a new branch from clean master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.