Respect ini session.use_strict_mode #319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rhertogh
commented
Sep 7, 2020
rhertogh
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ✔️ |
| Breaks BC? | ✔️/❌Only if Session::openSession() and/or Session::writeSession() are overwritten. |
| Tests pass? | ❌ |
| Fixed issues | Mongodb implementation for yiisoft/yii2#18247 |
Contributor
Author
|
@samdark I suggest increasing the minor version to 2.2.0 because the Yii2 version constraint is increased significantly. |
8 tasks
samdark
requested changes
Oct 30, 2020
Co-authored-by: Alexander Makarov <[email protected]>
removed obsolete dev requirement for yii2
added @SInCE to Collection::documentExists
Contributor
Author
|
@samdark Feedback has been applied |
Member
|
@rhertogh would you please into tests failure? Thanks. |
… respect_ini_session_use_strict_mode
Member
|
Oh, dreaded |
Member
|
Thank you! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.