Skip to content

Conversation

@kulavvy
Copy link
Contributor

@kulavvy kulavvy commented Feb 28, 2020

Q A
Is bugfix? no
New feature? yes
Breaks BC? BC?
Tests pass? idk, pull access denied for yiitest/php-base
Fixed issues #174

@samdark samdark added the type:enhancement Enhancement label Mar 2, 2020
@samdark samdark requested a review from a team March 2, 2020 14:58
@samdark samdark added this to the 2.0.12 milestone Mar 2, 2020
Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall 👍 Please add a note for README and phpdoc for new property. Thanks.

@kulavvy kulavvy requested a review from samdark March 5, 2020 16:17
@samdark samdark added the status:ready for merge The pull request is OK to be merged. label Mar 12, 2020
@samdark samdark merged commit 306afd8 into yiisoft:master Mar 13, 2020
@samdark
Copy link
Member

samdark commented Mar 13, 2020

Thank you 👍

@samdark samdark removed the status:ready for merge The pull request is OK to be merged. label Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:enhancement Enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants