Skip to content

Call onclose when closing the connection in the checkinterval #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Call onclose when closing the connection in the checkinterval #93

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8968d68
Call onclose when closing the connection in the check interval
johnstleger Feb 2, 2022
2f33ae2
Amend types and build
johnstleger Feb 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/y-websocket.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,18 @@ export class WebsocketProvider extends Observable {
if (this.wsconnected && messageReconnectTimeout < time.getUnixTime() - this.wsLastMessageReceived) {
// no message received in a long time - not even your own awareness
// updates (which are updated every 15 seconds)
/** @type {WebSocket} */ (this.ws).close()

if (!this.ws) {
setupWS(this);
return;
};

this.ws.close();

if (typeof this.ws.onclose === 'function') {
// ws.onclose is not called after the websocket is closed manually in Safari
this.ws.onclose(new CloseEvent('manual close'));
}
}
}, messageReconnectTimeout / 10))
if (connect) {
Expand Down