Skip to content

Fix PHPUnit deprecation warnings #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2025
Merged

Fix PHPUnit deprecation warnings #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions test/ZammadAPIClient/Resource/AbstractBaseTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
use PHPUnit\Framework\TestCase;

use ZammadAPIClient\Client;
use ZammadAPIClient\Exception\AlreadyFetchedObjectException;

abstract class AbstractBaseTest extends TestCase
{
Expand Down Expand Up @@ -190,11 +191,12 @@ public function testGet()
}

/**
* @expectedException \ZammadAPIClient\Exception\AlreadyFetchedObjectException
* @depends testCreate
*/
public function testGetOnFilledObjects()
{
$this->expectException(AlreadyFetchedObjectException::class);

foreach ( self::$created_objects as $created_object ) {
$created_object_id = $created_object->getID();
if ( empty( $created_object_id) ) {
Expand Down Expand Up @@ -328,11 +330,12 @@ public function testAllPagination()
}

/**
* @expectedException \ZammadAPIClient\Exception\AlreadyFetchedObjectException
* @depends testCreate
*/
public function testAllOnFilledObjects()
{
$this->expectException(AlreadyFetchedObjectException::class);

foreach ( self::$created_objects as $created_object ) {
$created_object_id = $created_object->getID();
if ( empty( $created_object_id) ) {
Expand Down
13 changes: 6 additions & 7 deletions test/ZammadAPIClient/Resource/TicketTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

namespace ZammadAPIClient\Resource;

use ZammadAPIClient\Exception\AlreadyFetchedObjectException;
use ZammadAPIClient\ResourceType;

class TicketTest extends AbstractBaseTest
Expand Down Expand Up @@ -189,11 +190,7 @@ public function testCreate( $values, $expected_success, $expected_article_count

// Compare article data.
$articles = $object->getTicketArticles();
$this->assertInternalType(
'array',
$articles,
'Articles of ticket object must be returned as array.'
);
$this->assertIsArray($articles);

$this->assertCount(
$expected_article_count,
Expand Down Expand Up @@ -226,11 +223,12 @@ public function testGet()
}

/**
* @expectedException \ZammadAPIClient\Exception\AlreadyFetchedObjectException
* @depends testCreate
*/
public function testGetOnFilledObjects()
{
$this->expectException(AlreadyFetchedObjectException::class);

return parent::testGetOnFilledObjects();
}

Expand Down Expand Up @@ -259,11 +257,12 @@ public function testAllPagination()
}

/**
* @expectedException \ZammadAPIClient\Exception\AlreadyFetchedObjectException
* @depends testCreate
*/
public function testAllOnFilledObjects()
{
$this->expectException(AlreadyFetchedObjectException::class);

return parent::testAllOnFilledObjects();
}

Expand Down