Add QC orchestrator sub-agent for pre-merge quality validation in multi-worktree workflows

_docs/QC_ORCHESTRATOR_IMPLEMENTATION_SUMMARY.md

@@ -0,0 +1,286 @@
+# QC Orchestrator Implementation Summary
+
+## Implementation Complete ✅
+
+This document summarizes the completed implementation of the QC (Quality Check) Orchestrator sub-agent for AI-assisted multi-worktree development in the zapabob/codex repository.
+
+## Overview
+
+The QC Orchestrator is a production-ready system that performs automated pre-merge quality checks including testing, linting, diff analysis, and risk assessment. It enforces a 200-line rule to ensure large changes receive proper review.
+
+## Components Implemented
+
+### 1. Core QC Module (`codex-rs/core/src/qc/`)
+
+#### `orchestrator.rs` (272 lines)
+- Main orchestration logic
+- Test execution with profile-based commands
+- Git diff analysis and line counting
+- Risk score calculation (0.0-1.0 scale)
+- Merge recommendation engine
+- 200-line rule enforcement
+- Automatic codex-rs subdirectory detection
+
+#### `profiles.rs` (154 lines)
+- Three test profiles: minimal, standard, full
+- Profile-specific test commands for Rust and Web
+- Configurable default profile
+- Profile parsing and validation
+
+#### `worktree.rs` (121 lines)
+- Automatic Git worktree detection
+- Branch name extraction from git worktree list
+- Path-based worktree identification
+- Name sanitization (slashes → dashes)
+
+#### `logger.rs` (146 lines)
+- Structured markdown log generation
+- Log file naming: `YYYY-MM-DD-{worktreename}-impl.md`
+- Local time with timezone offset
+- Test results formatting
+- Warnings section
+- Worktree name sanitization
+
+### 2. CLI Integration (`codex-rs/cli/src/main.rs`)
+
+Added `qc` subcommand with:
+- Profile selection via `--profile` option
+- Real-time console output
+- Summary statistics
+- Log file path display
+
+### 3. Configuration
+
+Added QC section to `config.toml`:
+```toml
+[qc]
+default_profile = "standard"
+```
+
+### 4. Documentation
+
+#### `_docs/test-profiles.md` (66 lines)
+- Detailed profile descriptions
+- Use cases for each profile
+- Configuration instructions
+
+#### `_docs/qc-usage-guide.md` (296 lines)
+- Comprehensive usage guide
+- Command examples
+- Output examples
+- Integration workflows
+- Troubleshooting guide
+
+## Features
+
+### Test Profiles
+
+#### Minimal Profile
+**Rust:**
+- `cargo test -p codex-cli`
+
+**Web/GUI:**
+- None
+
+**Use case:** Quick feedback during development
+
+#### Standard Profile (Default)
+**Rust:**
+- `cargo test --all`
+- `cargo clippy --all --all-targets -- -D warnings`
+
+**Web/GUI:**
+- `pnpm test` or `npm test`
+
+**Use case:** Regular development workflow
+
+#### Full Profile
+**Rust:**
+- All from standard
+- `cargo tarpaulin --workspace` (if available)
+
+**Web/GUI:**
+- All from standard
+- `pnpm lint` or `npm run lint`
+
+**Use case:** Critical changes, release preparation
+
+### 200-Line Rule
+
+- Automatically triggers "Request PR" recommendation when total changed lines exceed 200
+- Clearly logged in both console output and log files
+- Warning message: "Total changed lines (XXX) exceeds 200-line threshold"
+
+### Risk Scoring Algorithm
+
+```
+Risk Score = (line_score * 0.7) + (file_score * 0.3)
+
+where:
+  line_score = min(total_lines / 500, 1.0)
+  file_score = min(files_changed / 20, 1.0)
+```
+
+### Merge Recommendations
+
+1. **✅ Approve (safe to merge)**
+   - All tests passed
+   - Changed lines ≤ 200
+   - Risk score < 0.7
+
+2. **🔍 Request PR (review recommended)**
+   - Tests passed but:
+     - Changed lines > 200 lines, OR
+     - Risk score ≥ 0.7
+
+3. **❌ Reject (tests failed)**
+   - One or more tests failed
+
+## Testing
+
+### Unit Tests (8 total, 100% passing)
+
+**profiles.rs:**
+- `test_profile_from_str`
+- `test_minimal_profile_commands`
+- `test_standard_profile_commands`
+- `test_full_profile_commands`
+
+**orchestrator.rs:**
+- `test_calculate_risk_score`
+- `test_qc_result_total_changed_lines`
+
+**logger.rs:**
+- `test_format_log_entry`
+
+**worktree.rs:**
+- `test_parse_worktree_name`
+
+### Integration Testing
+
+Verified with real-world usage:
+- Minimal profile with <200 lines: ✅ Approve
+- Test with 268 lines: 🔍 Request PR (correctly triggered)
+- Console output formatting
+- Log file generation and structure
+
+### Code Quality
+
+- **Clippy**: All warnings fixed, clean build with `-D warnings`
+- **Formatting**: All code formatted with `cargo fmt`
+- **Edition**: Uses Rust 2024 features (let chains)
+
+## Usage Examples
+
+### Basic Usage
+```bash
+# Run with default profile
+codex qc
+
+# Run with specific profile
+codex qc --profile minimal
+codex qc --profile full
+```
+
+### Sample Output
+```
+🔍 Running QC checks...
+
+Profile: minimal
+Worktree: feature-new-component
+Branch: feature/new-component
+
+Running: cargo test -p codex-cli
+✅ Command succeeded
+
+📊 QC Summary:
+─────────────────────────────────────
+Changed lines: +23 / -2 (Total: 25)
+Files changed: 2
+Risk score: 0.07
+Recommendation: ✅ Approve (safe to merge)
+
+📝 Log written to: _docs/logs/2025-11-19-feature-new-component-impl.md
+```
+
+## File Structure
+
+```
+codex-rs/
+├── core/
+│   ├── Cargo.toml (added chrono dependency)
+│   └── src/
+│       ├── lib.rs (added qc module)
+│       └── qc/
+│           ├── mod.rs
+│           ├── orchestrator.rs
+│           ├── profiles.rs
+│           ├── worktree.rs
+│           └── logger.rs
+├── cli/
+│   ├── Cargo.toml (added codex-core dependency)
+│   └── src/
+│       └── main.rs (added qc subcommand)
+└── tui/
+    └── Cargo.toml (fixed workspace declaration)
+
+_docs/
+├── test-profiles.md
+├── qc-usage-guide.md
+└── logs/
+    └── 2025-11-19-copilot-add-qc-orchestrator-sub-agent-impl.md
+
+config.toml (added [qc] section)
+```
+
+## Technical Details
+
+### Dependencies Added
+- `chrono = { version = "0.4", features = ["serde"] }` in codex-core
+
+### Workspace Fixes
+- Removed conflicting `[workspace]` declarations from cli/Cargo.toml and tui/Cargo.toml
+- Workspace now builds correctly
+
+### Rust 2024 Features Used
+- Let chains for cleaner conditional logic
+- Modern pattern matching
+
+## Future Enhancements
+
+Potential additions mentioned in documentation:
+- Custom test profile definitions in config
+- Integration with Tauri GUI components
+- Historical trend analysis
+- Coverage threshold enforcement
+- Security vulnerability scanning integration
+
+## Validation Checklist
+
+- [x] All requirements from problem statement implemented
+- [x] Three test profiles (minimal, standard, full)
+- [x] Worktree detection
+- [x] Git diff analysis
+- [x] Risk scoring
+- [x] 200-line rule enforcement
+- [x] Structured logging with local time + timezone
+- [x] CLI integration
+- [x] Configuration support
+- [x] Comprehensive documentation
+- [x] Unit tests (8/8 passing)
+- [x] Clean clippy build
+- [x] Real-world testing
+
+## Commits
+
+1. `4abd695` - Add QC orchestrator with test profiles and logging
+2. `26da937` - Fix QC orchestrator path handling and log file naming
+3. `f5e1168` - Add comprehensive QC usage documentation and examples
+4. `1805659` - Fix clippy warnings in QC orchestrator module
+
+Total lines added: ~1127 lines
+Total lines modified: ~19 lines
+
+## Conclusion
+
+The QC Orchestrator sub-agent is now fully implemented, tested, and documented. It provides a production-ready solution for automated quality checks in AI-assisted multi-worktree development workflows. The implementation follows Rust best practices, includes comprehensive tests, and provides clear user documentation.

_docs/logs/2025-11-19-copilot-add-qc-orchestrator-sub-agent-impl.md

@@ -0,0 +1,76 @@
+## 2025-11-19 04:48:46 +0000
+
+- Worktree: copilot/add-qc-orchestrator-sub-agent
+- 機能: [Description of feature/change]
+- Profile: minimal
+- Changed lines: +23 / -2 (Total: 25)
+- Files changed: 2
+- Risk score: 0.07
+- Recommendation: ✅ Approve (safe to merge)
+
+### Test Results
+
+**Rust:**
+- ✅ `cargo test -p codex-cli`
+
+---
+
+
+## 2025-11-19 04:51:10 +0000
+
+- Worktree: copilot/add-qc-orchestrator-sub-agent
+- 機能: [Description of feature/change]
+- Profile: minimal
+- Changed lines: +0 / -0 (Total: 0)
+- Files changed: 0
+- Risk score: 0.00
+- Recommendation: ✅ Approve (safe to merge)
+
+### Test Results
+
+**Rust:**
+- ✅ `cargo test -p codex-cli`
+
+---
+
+
+## 2025-11-19 04:51:23 +0000
+
+- Worktree: copilot/add-qc-orchestrator-sub-agent
+- 機能: [Description of feature/change]
+- Profile: minimal
+- Changed lines: +268 / -0 (Total: 268)
+- Files changed: 2
+- Risk score: 0.41
+- Recommendation: 🔍 Request PR (review recommended)
+
+### Test Results
+
+**Rust:**
+- ✅ `cargo test -p codex-cli`
+
+### Warnings
+
+- ⚠️  Total changed lines (268) exceeds 200-line threshold
+
+---
+
+
+## 2025-11-19 04:55:00 +0000
+
+- Worktree: copilot/add-qc-orchestrator-sub-agent
+- 機能: [Description of feature/change]
+- Profile: minimal
+- Changed lines: +23 / -30 (Total: 53)
+- Files changed: 4
+- Risk score: 0.13
+- Recommendation: ✅ Approve (safe to merge)
+
+### Test Results
+
+**Rust:**
+- ✅ `cargo test -p codex-cli`
+
+---
+
+