- 
                Notifications
    You must be signed in to change notification settings 
- Fork 14
versus workflows: Update existing PR if any instead of closing/opening #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| This will not work as intended, the step  I'd also prefer that we don't fail the workflow when the PR is just being updated, there's no reason to and just creates noise (still getting one each day). | 
| I'll look at the first point. (or  | 
| I updated the juiceshop workflow, does that address your first concern? | 
6d6604a    to
    9e5b266      
    Compare
  
    | Seems so, it's no longer pushing the latest from upstream. | 
| And which option for the failures or do you have another idea? | 
| I don't mind which way as long as it only fails if there's an actual failure (to create the PR or push the changes). | 
| In that case it would require something more like exit code logic, but I'm not sure they get specific enough. For the time being, let's narrow this PR down to adjusting the PR logic in other workflows. Then I can look at the failure logic in another? | 
| I'm fine with that, there aren't other ongoing PRs so failures should be minimal. | 
Signed-off-by: kingthorin <[email protected]>
| All adjusted. | 
Similar to the recent auth-tests addition.