Skip to content

Allow 'onPageSelected()' to fire on iOS as well #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow 'onPageSelected()' to fire on iOS as well #155

wants to merge 1 commit into from

Conversation

osagie
Copy link

@osagie osagie commented Jan 30, 2019

iOS builds would never fire the callback when the page is set programatically.

@osagie
Allow 'onPageSelected()' to fire on iOS as well
b250d3b 
iOS builds would never fire the callback when the page is set programatically.
williamgurzoni
williamgurzoni approved these changes Jun 25, 2019
View reviewed changes
Copy link

@williamgurzoni williamgurzoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its nice!

@williamgurzoni williamgurzoni mentioned this pull request Jun 25, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@williamgurzoni williamgurzoni williamgurzoni approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@osagie @williamgurzoni