- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1.1k
ci: add winget releaser workflow #2155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
519dbd7    to
    eed02b2      
    Compare
  
    | And how does it get approved? Can anyone change it then? | 
| A Winget moderator will approve it. Anyone can make changes to the package through a PR but it needs to be approved by a moderator. https://learn.microsoft.com/en-us/windows/package-manager/package/repository#submission-process | 
| @sitiom I've added the arm installer to the package in microsoft/winget-pkgs#194819. Can you change the regex to also match the arm installers? 
 | 
| 
 Done | 
| Could you add a space between the actions? so it can look like the entire action | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optimized builds have been removed with version 1.0.2-b.4
https://github.com/zen-browser/desktop/wiki/Why-have-optimized-builds-been-removed%3F
a00a0de    to
    3dd2981      
    Compare
  
    | I just added Twilight builds to Winget and started writing the whole code for a PR, only to find out that this PR was opened🤣. I would recommend changing your code to something like the following:   winget-release:
  name: Winget Release
  runs-on: ubuntu-latest
  needs: [build-data, release]
  steps:
    - name: Winget Twilight Release
      if: ${{ inputs.update_branch == 'twilight' }}
      uses: vedantmgoyal2009/winget-releaser@a3ac67b0c3026bc335a33b722188e3ec769d6a64
      with:
        identifier: Zen-Team.Zen-Browser.Twilight
        version: ${{ needs.build-data.outputs.version }}
        max-versions-to-keep: 1
        installers-regex: 'zen\.installer(-arm64)?\.exe$'
        token: ${{ secrets.WINGET_TOKEN }}
    - name: Winget Stable Release
      if: ${{ inputs.update_branch == 'release' }}
      uses: vedantmgoyal2009/winget-releaser@a3ac67b0c3026bc335a33b722188e3ec769d6a64
      with:
        identifier: Zen-Team.Zen-Browser
        version: ${{ needs.build-data.outputs.version }}
        installers-regex: 'zen\.installer(-arm64)?\.exe$'
        token: ${{ secrets.WINGET_TOKEN }} | 
3dd2981    to
    d13fa57      
    Compare
  
    | For security reasons I would recommend this change for both releases, this ensures that if any malicious code is committed to the workflow, it should not affect this repo: uses: vedantmgoyal9/winget-releaser@a3ac67b0c3026bc335a33b722188e3ec769d6a64 | 
| 
 The same could apply to the other actions pinned against a tag; I'm just following the code in the workflow. So it would be up to @mauro-balades | 
| This can be done by using dependabot aswell | 
| Updates: 
 | 
Co-authored-by: UnownPlain <[email protected]> Signed-off-by: Ryan <[email protected]>
Co-authored-by: UnownPlain <[email protected]> Signed-off-by: Ryan <[email protected]>
| Approved. | 
Continuation of #637