feat: update MobileMenu for upgraded accessibility [signed] #751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now the commit is signed with gpg. |
|
@taroj1205 could you check this out. And @michi-onl LGTM, the style may be if basing off the footer. |
|
@taroj1205 will there be any updates regarding merging this pull request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I redesigned the mobile menu because I thought it was too cluttered. Since the pointer isn’t available on mobile, there was no accessible way to differentiate between what’s on the desktop dropdown title and its links.
Now, the links are smaller and the indentation has been removed. Additionally, the download link is now a large button, similar to the one on the NavBar on large screens.