Updates for windows #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating the code to replace the backslashes from windows file paths to forward slashes to support how glob works with JS
Updating the code to replace the backslashes from windows file paths to forward slashes to support how glob works with JS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zendesk/vegemite
Description
The two files in the rollup folder do not work properly when trying to build the package on a Windows machine.
Since Window's uses backslashes for it's directory separator it becomes and issue when the build function tries to copy the manifest file and the files from the assets.
Updating these two files to replace the backslashes with forward slashes resolved the issue and allowed npm to properly build the files.
I both replicated the initial issue where npm build was NOT able to copy over the assets and manifest, then applied these two changes and confirmed it was able to build the package successfully.
Please let me know if you have any questions
Thanks!
Todd