Skip to content

Conversation

strickvl
Copy link
Contributor

@strickvl strickvl commented Sep 9, 2025

This PR implements Phase 1 of descriptive page titles for the OSS dashboard.

What's included

  • New usePageTitle hook that maps routes to descriptive titles.
  • Hook is wired at RootLayout, so all pages (incl. public) update document.title.
  • Coverage includes Overview, Projects, Stacks, Components, Pipelines, Pipeline Runs, Models, Artifacts, Run Templates, and granular Settings pages.

Why

  • Clearer tab identification and improved accessibility/navigation.

How

  • Lightweight, synchronous mapping using matchPath and routes constants.

Validation

  • Navigate through the app and confirm titles (
    - ZenML Dashboard).
  • Run pnpm lint and pnpm format.

Future Work

  • Dynamic titles for detail routes resolved via React Query:
    • Runs: Run <name or shortId> using a useRun(runId)-style query.
    • Components detail/edit: Component <name or id>.
    • Pipelines by namespace: Pipeline <namespace>.
  • Approach: start with a generic title; when query data resolves, refine the title once to avoid flicker.

- Add `usePageTitle` hook with route mapping
- Wire into `RootLayout` to cover public + app routes
- Granular Settings labels (Members, API Tokens, Notifications, Secrets(+detail), Connectors, Service Accounts, Profile, General)
- Project-scoped labels (Repositories, Profile)

Validation:
- pnpm dev and confirm “<Section> - ZenML Dashboard” updates on navigation
- pnpm lint, pnpm format
Copy link
Contributor

coderabbitai bot commented Sep 9, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/add-page-titles

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@strickvl
Copy link
Contributor Author

strickvl commented Sep 9, 2025

@Cahllagerfeld just was made aware of the decisions that any PRs where AI models are used will not get reviewed, so I would probably then just close this PR since it won't get merged then.

@strickvl strickvl closed this Sep 9, 2025
@strickvl strickvl reopened this Sep 9, 2025
Copy link
Contributor Author

@strickvl strickvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant