Skip to content

Conversation

bcdurak
Copy link
Contributor

@bcdurak bcdurak commented Jul 7, 2025

Describe changes

I implemented/fixed _ to achieve _.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
  • IMPORTANT: I made sure that my changes are reflected properly in the following resources:
    • ZenML Docs
    • Dashboard: Needs to be communicated to the frontend team.
    • Templates: Might need adjustments (that are not reflected in the template tests) in case of non-breaking changes and deprecations.
    • Projects: Depending on the version dependencies, different projects might get affected.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@bcdurak bcdurak requested a review from schustmi July 7, 2025 13:42
Copy link
Contributor

coderabbitai bot commented Jul 7, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/PRD-3752-adding-verbosity-levels-to-log-messages

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@bcdurak bcdurak linked an issue Jul 7, 2025 that may be closed by this pull request
Copy link
Contributor

@schustmi schustmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thought I had: Now that we're not wrapping stderr anymore, exceptions probably won't show up in the logs anymore, correct?

@bcdurak
Copy link
Contributor Author

bcdurak commented Jul 16, 2025

One more thought I had: Now that we're not wrapping stderr anymore, exceptions probably won't show up in the logs anymore, correct?

Yes and no. We usually wrap the step and pipeline executions in try-except clauses and we capture any exceptions that happen through the regular logging.error() calls. It is not as detailed as the actual traceback, but it is at least visible through the logs. Would that be enough in your opinion? Otherwise, we can log more when an error occurs as well.

@bcdurak bcdurak requested a review from schustmi July 16, 2025 12:21
@bcdurak
Copy link
Contributor Author

bcdurak commented Jul 21, 2025

@schustmi Since we weren't dealing with the stderr anymore, I didn't want to rely on any error logging messages and I have added this now. Take a look, let me know what you think.

@bcdurak bcdurak requested a review from schustmi August 5, 2025 12:21
@bcdurak bcdurak requested a review from schustmi August 7, 2025 13:08
@bcdurak bcdurak self-assigned this Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal To filter out internal PRs and issues python Pull requests that update Python code run-slow-ci
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepend log level to captured logs
2 participants