Skip to content

Issue fill path #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Issue fill path #22

wants to merge 18 commits into from

Conversation

k1w1
Copy link

@k1w1 k1w1 commented Aug 22, 2022 •
edited
Loading

Support filling and stroking paths. Allows code like:

const path = ctx.createPath(`M 230 80
    A 45 45, 0, 1, 0, 275 125
    L 275 80 Z`);

ctx.strokeStyle = 'red';
ctx.stroke(path);

Fixes #20

k1w1 and others added 18 commits July 15, 2022 17:57
@k1w1
Merge pull request #1 from aha-app/feature-add-ellipse
c4fe520 
Feature add ellipse
@k1w1
Merge pull request #2 from aha-app/issue-arc-scaling
95702ef 
Fix rendering of arcTo when a scale is applied
@k1w1
Merge pull request #3 from aha-app/issue-ellipse-translate-problem
f09378a 
Issue ellipse translate problem
@k1w1
Merge pull request #4 from aha-app/issue-scale-lineWidth
67d5dfd 
Apply to scale to lineWidth.
@k1w1
Support independent paths
7f59355
@k1w1
Merge pull request #5 from zenozeng/main
722bb9c 
Bring in changes from zenozeng/svgcanvas
@k1w1
Merge branch 'main' into issue-fill-path
127009a
@k1w1
Test for scale/translate/rotate. Currently failing
a61b048
@k1w1
Apply transform to paths
f43ff8b
@k1w1
Built for npm
f3cac33
@k1w1
Added clipping test
fd02467
@k1w1
Fixed clipping behavior and handling of save/restore around stroke an…
4f7bcfe 
…d fill.
@k1w1
Force all images to be inline bitmaps.
7fe0aea 
Otherwise the SVGs we generate can't be opened by editing tools like Figma.
@k1w1
Fixed arcTo implementation. Previously it only worked in the orientat…
9d7c7ba 
…ion in the test, but not for lines curving in other directions.
@k1w1
Added roundRect support
130fe48
@k1w1
Added note about active branch
cc6973f
@k1w1
Support addPath properly.
a891b0a 
However this is not correctly handling the transform. To do it correctly we need to store the sub-paths in the path in their original form (not a string) and apply the transforms at render time.
@k1w1
Add hack to prevent incorrectly scaled stroke
2e5bd80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Calling Context.fill with a path does not work

1 participant

@k1w1