Update wallet list #872
Merged
Update wallet list #872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 build.zip [updated at Dec 1, 9:09:33 PM UTC] |
There was a problem hiding this comment.
Pull request overview
This PR implements a wallet list management feature that allows users to customize the order of their wallets through a drag-and-drop interface. The implementation introduces a persistent wallet ordering system that affects how wallets are displayed throughout the application.
Key changes:
- Added drag-and-drop wallet reordering functionality with an edit mode toggle
- Introduced a
walletsOrderpreference that persists wallet grouping and ordering - Refactored wallet list rendering to respect the custom order across multiple pages
Reviewed changes
Copilot reviewed 12 out of 14 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
src/ui/pages/WalletSelect/shared.ts |
New shared utility for merging saved wallet order with actual wallet data |
src/ui/pages/WalletSelect/WalletListEdit.tsx |
New component implementing drag-and-drop wallet reordering using @dnd-kit |
src/ui/pages/WalletSelect/WalletSelect.tsx |
Updated to support edit mode and pass walletsOrder to child components |
src/ui/pages/WalletSelect/WalletList.tsx |
Refactored to render wallets according to walletsOrder preference |
src/ui/pages/SendForm/fieldsets/AddressInput/AddressInput.tsx |
Updated address suggestions to respect wallet order |
src/ui/pages/RequestAccounts/RequestAccounts.tsx |
Updated to pass walletsOrder to WalletList |
src/ui/features/xp-drop/XpDropClaimFlow/XpDropClaim.tsx |
Updated to pass walletsOrder to WalletList |
src/ui/features/referral-program/Invite.tsx |
Updated to pass walletsOrder to WalletList |
src/shared/wallet/wallet-list.ts |
New utility defining wallet list data structures and helper functions |
src/background/Wallet/model/types.ts |
Added walletsOrder to PublicPreferences type |
src/background/Wallet/WalletRecord.ts |
Added DEFAULT_WALLET_LIST_GROUPS as default preference value |
src/ui/assets/drag.svg |
New drag handle icon for the reorder interface |
package.json & package-lock.json |
Added @dnd-kit dependencies for drag-and-drop functionality |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
zerts
force-pushed
the
task/extension-improve-wallet-list-WLT-8389
branch
from
cd58671 to
8493eac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.