Skip to content

fix exception on attachShadow #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix exception on attachShadow #131

wants to merge 1 commit into from

Conversation

@hackwaly
Copy link

@hackwaly hackwaly commented Dec 31, 2024

image

@zerodevx
Copy link
Owner

zerodevx commented Jan 10, 2025

Thanks for your PR - can I check what are the steps to reproduce this issue?

@hackwaly
Copy link
Author

hackwaly commented Jan 10, 2025

Thanks for your PR - can I check what are the steps to reproduce this issue?

Sorry, It's in my work project. I haven't found a minimal reproduce. I'm using react framework.

@zerodevx
Copy link
Owner

zerodevx commented Jan 10, 2025

Shadow doms can be nested, so even if your project uses custom elements, it shouldn't be a problem. I'm not how there can be more than 1 shadow root in the <zero-md> element. Will definitely need a minimal reproduction to know more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hackwaly @zerodevx