Skip to content

Conversation

@ws4charlie
Copy link
Contributor

Description

This PR does the following:

  1. Deploys sui gateway v1.0.0 and then upgrades it to v2.0.0 in the setup_sui.go.
  2. Deploys example package (without referencing Gateway object)

The make start-sui-test failed

image

How Has This Been Tested?

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 5, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch test-WaC-example-deployment-gateway-v2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.74%. Comparing base (0e61fa5) to head (4e6079f).
⚠️ Report is 18 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4417      +/-   ##
===========================================
- Coverage    64.75%   64.74%   -0.01%     
===========================================
  Files          469      469              
  Lines        28518    28508      -10     
===========================================
- Hits         18466    18458       -8     
+ Misses        9031     9030       -1     
+ Partials      1021     1020       -1     
Files with missing lines Coverage Δ
zetaclient/chains/sui/signer/withdraw_and_call.go 81.17% <100.00%> (+0.04%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ws4charlie ws4charlie changed the title test: deploy sui example package using upgraded gateway v2 test: (don't merge) deploy sui example package using upgraded gateway v2 Nov 10, 2025
@lumtis
Copy link
Contributor

lumtis commented Dec 1, 2025

@ws4charlie can be closed?

Base automatically changed from fix-remove-gateway-reference-from-sui-example to develop December 1, 2025 20:33
@ws4charlie
Copy link
Contributor Author

I'm closing this test branch since we were able to deploy the example package in Sui testnet after 4414.

@ws4charlie ws4charlie closed this Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants