Skip to content

Conversation

@hazeycode
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings August 31, 2025 15:28

This comment was marked as outdated.

@hazeycode hazeycode marked this pull request as draft August 31, 2025 15:34
@Srekel
Copy link
Member

Srekel commented Aug 31, 2025

Thank you! This is the migration part I find least... enticing 😅 also not sure when we will upgrade to zig 0.15.

If this is done I'm happy to merge!

@hazeycode hazeycode force-pushed the zig-0.15.1 branch 2 times, most recently from 101f47d to d4f97b7 Compare August 31, 2025 16:31
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the codebase from Zig 0.14.0 to Zig 0.15.1, updating function calling conventions and build system configuration to align with the newer Zig version.

Key changes include:

  • Updated calling convention syntax from .C to .c throughout function type definitions
  • Modified build system to use new module and library creation patterns
  • Fixed memory alignment API calls and function parameter ordering

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/zflecs.zig Updated calling conventions, fixed alignment API usage, and corrected function parameter order
src/tests.zig Updated calling conventions and simplified test struct implementation
build.zig.zon Bumped minimum Zig version requirement to 0.15.1
build.zig Refactored build system to use new module and library creation APIs

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@hazeycode
Copy link
Member Author

hazeycode commented Aug 31, 2025

Should be good now. I havn't tested in a real example but the tests are passing so I'll mark this as "ready" on that basis.

@hazeycode hazeycode marked this pull request as ready for review August 31, 2025 16:36
@Srekel
Copy link
Member

Srekel commented Aug 31, 2025

Works for me! We will test it once we upgrade Tides :)

@Srekel Srekel merged commit a1b7a83 into main Aug 31, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants