feat: adopt with Zig 0.15 #114
Conversation
fix up to 04-03
jiacai2050
force-pushed
the
feat-0.15
branch
from
22faf35 to
ec67ecd
Compare
|
/gemini review |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Zig Cookbook to be compatible with Zig version 0.15. The changes include updating API calls, method names, and build configurations to match the new version's requirements.
- Update Zig version from 0.14.x to 0.15.x across the codebase
- Replace deprecated API methods with their Zig 0.15 equivalents
- Update build system configurations for the new version
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updates version tracking information to Zig 0.15.x |
| .github/workflows/ci.yml | Bumps CI Zig version from 0.14.1 to 0.15.1 |
| build.zig.zon | Updates zigcli dependency from v0.2.3 to v0.3.0 |
| build.zig | Updates build system API calls for Zig 0.15 compatibility |
| src/*/01-01-read-file-line-by-line.smd | Updates documentation to reflect API method name change |
| assets/src/*.zig | Updates various source files with new API methods and patterns |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| defer server.deinit(); | ||
|
|
||
| log.info("Start HTTP server at {any}", .{addr}); | ||
| log.info("Start HTTP server at {f}", .{addr}); |
There was a problem hiding this comment.
The format specifier {f} is for floating point numbers, but addr is a network address. This should be {any} to properly format the address.
| log.info("Start HTTP server at {f}", .{addr}); | |
| log.info("Start HTTP server at {any}", .{addr}); |
Copilot uses AI. Check for mistakes.
| defer conn.stream.close(); | ||
|
|
||
| log.info("Got new client({any})!", .{conn.address}); | ||
| log.info("Got new client({f})!", .{conn.address}); |
There was a problem hiding this comment.
The format specifier {f} is for floating point numbers, but conn.address is a network address. This should be {any} to properly format the address.
| log.info("Got new client({f})!", .{conn.address}); | |
| log.info("Got new client({any})!", .{conn.address}); |
Copilot uses AI. Check for mistakes.
| var buf: [1024]u8 = undefined; | ||
|
|
||
| print("Listen on {any}...\n", .{addr}); | ||
| print("Listen on {f}\n", .{addr}); |
There was a problem hiding this comment.
The format specifier {f} is for floating point numbers, but addr is a network address. This should be {any} to properly format the address.
| print("Listen on {f}\n", .{addr}); | |
| print("Listen on {any}\n", .{addr}); |
Copilot uses AI. Check for mistakes.
| const stream = try net.tcpConnectToAddress(peer); | ||
| defer stream.close(); | ||
| print("Connecting to {}\n", .{peer}); | ||
| print("Connecting to {f}\n", .{peer}); |
There was a problem hiding this comment.
The format specifier {f} is for floating point numbers, but peer is a network address. This should be {any} to properly format the address.
| print("Connecting to {f}\n", .{peer}); | |
| print("Connecting to {any}\n", .{peer}); |
Copilot uses AI. Check for mistakes.
|
|
||
| print("{} says {s}\n", .{ client.address, message }); | ||
| fn handleClient(client: net.Server.Connection) !void { | ||
| print("Accepted connection from {f}\n", .{client.address}); |
There was a problem hiding this comment.
The format specifier {f} is for floating point numbers, but client.address is a network address. This should be {any} to properly format the address.
Copilot uses AI. Check for mistakes.
| var writer = client.stream.writer(&.{}); | ||
|
|
||
| while (true) { | ||
| print("Waiting for data from {f}...\n", .{client.address}); |
There was a problem hiding this comment.
The format specifier {f} is for floating point numbers, but client.address is a network address. This should be {any} to properly format the address.
Copilot uses AI. Check for mistakes.
| print("Waiting for data from {f}...\n", .{client.address}); | ||
| const msg = reader.interface().takeDelimiterInclusive('\n') catch |err| { | ||
| if (err == error.EndOfStream) { | ||
| print("{f} closed the connection\n", .{client.address}); |
There was a problem hiding this comment.
The format specifier {f} is for floating point numbers, but client.address is a network address. This should be {any} to properly format the address.
| print("{f} closed the connection\n", .{client.address}); | |
| print("{any} closed the connection\n", .{client.address}); |
Copilot uses AI. Check for mistakes.
| return err; | ||
| } | ||
| }; | ||
| print("{f} says {s}", .{ client.address, msg }); |
There was a problem hiding this comment.
The format specifier {f} is for floating point numbers, but client.address is a network address. This should be {any} to properly format the address.
Copilot uses AI. Check for mistakes.
1 participant
Close #112