-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
compiler: update aro and translate-c to latest; delete clang translate-c #24497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andrewrk
wants to merge
7
commits into
master
Choose a base branch
from
aro-translate-c
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+40,994
−52,062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1c4bddc
to
960d68b
Compare
This was referenced Jul 18, 2025
the ziglang/translate-c package has its own test suite, so these are redundant
960d68b
to
81092b4
Compare
When trying to communicate CLI options to the translate-c executable these are not yet handled:
manually reduced command:
fails:
(truncated) |
aha, aro does not support clang's C runtime includes, which makes sense.
stderr.txt contains:
|
81092b4
to
9cff3c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deletes our implementation of translate-c which is based on libclang and replaces it with one based on arocc and translate-c.
Goodbye, and good riddance, to 5,940 lines of our remaining C++ code in the source repository, with 3,763 remaining.
Progress towards #20630. In the future, Zig will drop the
@cImport
language builtin, but for now, it remains, backed by Aro instead of Clang.Progress towards #16270
Upgrade Guide
This is technically a non-breaking change. While breakage is likely due to one C compiler being swapped out for another, if it occurs it is a bug rather than a feature.
So, cross your fingers when you upgrade and report a bug if something breaks.
Merge Checklist
jitCmd
, properly passing Compilation state (mainly include dirs and target information)