fix redundant safety checks being emitted for slicing #25202
+13
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xdBronch
commented
Sep 10, 2025
| @@ -32132,7 +32138,8 @@ fn analyzeSlice( | |||
| else | |||
| end; | |||
|
|
|||
| try sema.addSafetyCheckIndexOob(block, src, actual_end, actual_len, .cmp_lte); | |||
| if (try sema.resolveDefinedValue(block, src, actual_end) == null) | |||
There was a problem hiding this comment.
not gonna push for now since multiple things may be wrong, changing this to actual_len seems to fix what the CI is failing on. is that correct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #22398
wasnt sure if/how this should be tested, please lmk!