fix(behaviors): Ignore masked mods in key repeat - #3437
Open
jjiill888 wants to merge 1 commit into
Open
Conversation
When a mod-morph consumes a modifier, it masks it via zmk_hid_masked_modifiers_set() so the morphed keycode is sent without it. The key repeat behavior, however, captured zmk_hid_get_explicit_mods() unfiltered and stored it as implicit modifiers, and implicit modifiers bypass the mask when the HID report is built. Pressing shift, tapping a mod-morph that morphs to an unshifted keycode (e.g. COMMA -> SEMICOLON), releasing shift and then pressing &key_repeat therefore emitted ':' instead of a second ';'. Expose the masked modifiers and exclude them when capturing, so only modifiers that actually contributed to the output are repeated. Fixes zmkfirmware#3368
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a mod-morph consumes a modifier, it masks it via zmk_hid_masked_modifiers_set() so the morphed keycode is sent without it. The key repeat behavior, however, captured zmk_hid_get_explicit_mods() unfiltered and stored it as implicit modifiers, and implicit modifiers bypass the mask when the HID report is built.
Pressing shift, tapping a mod-morph that morphs to an unshifted keycode (e.g. COMMA -> SEMICOLON), releasing shift and then pressing &key_repeat therefore emitted ':' instead of a second ';'.
Expose the masked modifiers and exclude them when capturing, so only modifiers that actually contributed to the output are repeated.
Fixes #3368
PR check-list