main: Do not highlight options after --

[phy1729]

Re #491, something like this? It does incorrectly highlight -n as path in a case statement like

case a in --) foo;; a) cat -n .zshrc;; esac

(Should be single-hyphen-option; is highlighted as path.)

[danielshahaf]

Thanks for implementing this, and sorry for the very late review.

The test LGTM 👍. While reviewing the implementation found a minor issue which appears to be preëxisting, and filed it as #577.

[danielshahaf]

I think the variable may need to be reset to 0 in a few more cases: consider { cat -n -- -n } always { printf %s -n } and : > >(ls), both of which start a new simple command without using ZSH_HIGHLIGHT_TOKENS_COMMANDSEPARATOR tokens. That said, we seem not to get this correctly for other cases, either: raised that as #577.

Even more obscure: svnadmin freeze -- /path/to/foo/ ls -l. That -l is an option to ls, but in svnadmin the -- is required. Admittedly, most commands that execv() their positional arguments don't require a -- (for example, env -i /bin/ls -l), so maybe we should just accept this.

(For the curious, yes, that nests. svnadmin freeze -- foo/ svnadmin freeze -- bar/ ls -l is valid.)

[danielshahaf]

@phy1729 This is milestoned 0.8.0. Do you intend to work on it for the 0.8.0 release? If yes, great; if not, could you re-milestone it appropriately? Cheers.

[danielshahaf]

(Assigning until the question is answered. Feel free to unassign yourself if needed.)

[danielshahaf]

Triage: Bumping to the next milestone due to feedback timeout.