feat: Gemini Assistant Image Responses #1048
Open
+212
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erlendp
changed the title
Author
|
Is anyone able to take a look at this PR? We're looking to take some code to production soon, and it'd be nice to know our approach is validated by this library! |
Collaborator
|
Hi! I was basically waiting for #1050 to be merged but now that it's merged I can start merging everything else. Apologies for not communicating that sooner. You just need to resolve the branch conflicts. The implementation looks OK to me although I do think maybe we should just write a Responses API trait and provide Gemini's "completions" API through it at some point later on |
Author
|
@joshua-mo-143 Should be good to go now - I've also added some missing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for images in gemini assistant responses (i.e. gemini-2.5-flash-image)