feat(gemini-request): add response_json_schema to GenerationConfig #1077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the GenerationConfig struct to include the response_json_schema field. This enables support for standard JSON Schema formats per Gemini API docs.
joshua-mo-143
requested changes
Nov 24, 2025
Collaborator
joshua-mo-143
left a comment
joshua-mo-143
left a comment
There was a problem hiding this comment.
Small change required due to incorrect serde renaming.
joshua-mo-143
requested changes
Nov 24, 2025
| /// This is an alternative to responseSchema that accepts a standard JSON Schema. | ||
| /// If this is set, responseSchema must be omitted. | ||
| /// Compatible MIME type: application/json. | ||
| /// Supported properties: $id, $defs, $ref, type, properties, etc. |
Collaborator
There was a problem hiding this comment.
You need to swap the _response_json_schema and response_json_schema docstrings around
As suggested in the review, the docstrings for `_response_json_schema` and `response_json_schema` were swapped to be accurate.
joshua-mo-143
approved these changes
Nov 24, 2025
Collaborator
joshua-mo-143
left a comment
joshua-mo-143
left a comment
There was a problem hiding this comment.
lgtm, thanks for the PR!
Tested manually through temporarily adjusting the gemini_agent example locally
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1076