feat: return usage when streaming completions from a dynamic client #903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-mo-143
requested changes
Oct 7, 2025
joshua-mo-143
approved these changes
Oct 9, 2025
There was a problem hiding this comment.
LGTM, just waiting to merge #875 as it's a relatively crucial PR - need to make sure it doesn't get interrupted before it can be merged
|
Last merge had minor conflicts with my changes, but it should be resolved now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the implementation of my idea for providing the user with usage metadata when streaming completions using the dynamic client API, explained in #902.
Struct names and locations are very much up for debate, as I am not familiar with the project.
Fixes #902.