Improve scenario of timestamp check in Rio hardfork#2091
Open
Improve scenario of timestamp check in Rio hardfork#2091
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2091 +/- ##
===========================================
- Coverage 50.59% 50.58% -0.01%
===========================================
Files 875 875
Lines 151820 151824 +4
===========================================
- Hits 76815 76805 -10
- Misses 69929 69941 +12
- Partials 5076 5078 +2
... and 22 files with indirect coverage changes
🚀 New features to boost your workflow:
|
Removed detailed comments regarding block timestamp checks to simplify the code.
marcello33
approved these changes
Feb 28, 2026
|
marcello33
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Problem
The Rio HF relaxed
verifyHeader()'s timestamp check to support flexible block times, but leftheader.Timecompletely unbounded. A block withheader.Time = year 2126passes all validation. Once accepted,Prepare()computes a ~100-year delay and blocks forever.Fix
Add a 30-second upper bound on how far ahead of local clock a block timestamp may be:
Tests
Three cases added to
TestVerifyHeader:far-future timestamp in Rio mode is rejected (chain-halt attack)— year 2126 timestamp must returnErrFutureBlocktimestamp beyond allowed future bound in Rio mode is rejected— boundary check atnow + 35snormal timestamp in Rio mode is accepted— regression, valid blocks still passChanges
Breaking changes
No breaking changes