fix for stream server data race #2045
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliothllm
requested review from
eduadiez,
hexoscott,
mandrigin and
revitteth
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a data race issue in the stream server initialization by introducing a synchronization mechanism. The fix ensures that the PreStart method waits for the stream server to be fully initialized before attempting to use it.
Key Changes:
- Added a channel-based synchronization mechanism to signal when the stream server is ready
- Modified the stream server startup goroutine to signal readiness via channel closure
- Updated PreStart to wait for the ready signal before proceeding with stream server operations
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
make stream waiter chan have error
elliothllm
force-pushed
the
fix/stream-server-data-race
branch
from
db39041 to
e48c919
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue: #1962