Release/2.64 #2050
Open
Release/2.64 #2050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(blobrecovery): added basefee to blob recovery mode
Zkevm to 2.64
fix(ci): add write perms for google oidc
hexoscott
requested review from
eduadiez,
mandrigin and
revitteth
as code owners
There was a problem hiding this comment.
Pull Request Overview
This release adds retry functionality to JSON-RPC client calls, implements base fee recovery for blob recovery scenarios, and updates CI permissions. The changes focus on improving reliability during blob data recovery by handling retries and preserving historical base fee information.
Key changes:
- Added retry logic with configurable attempts and delays to JSON-RPC client
- Implemented base fee storage and retrieval for blob recovery scenarios
- Updated GitHub Actions workflow permissions
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| zkevm/jsonrpc/client/client.go | Adds retry mechanism with configurable options for JSON-RPC calls |
| zk/stages/stage_sequence_execute.go | Overrides block base fee during blob recovery with stored values |
| zk/stages/stage_sequence_blob_recovery.go | Stores base fee changes from blob data and adjusts execution catch-up logic |
| zk/hermez_db/db.go | Adds database table and methods for storing/retrieving recovery block base fees |
| erigon-lib/kv/tables.go | Registers new RECOVERY_BLOCK_BASE_FEE table in chaindata tables |
| zk/da/blob_da.go | Adds retry support to blob retrieval and handles empty result case |
| .github/workflows/ci_zkevm.yml | Adds id-token write permission for CI workflow |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fix: maxPriorityFeePerGas and feeHistory to return correct values
feat: avoid waiting l1 sync sleep finishes to finish l1 sync stage
don't pull GCR images in CI for kurtosis
turn off hive tests for release/* branches
…ind-pmt-2.64 unwind to correct block when unwinding pmt on rpc
…ind-pmt-2.64 unwind to correct block when unwinding pmt on rpc
Revert "Merge pull request #2052 from 0xPolygon/hotfix/2.64.0-RC7"
force sequencer to regenerate pmt on startup flag
…2.64 Feat/force pmt regen startup 2.64
fix(sequencer): stagestate update on inters
fix: gas price tracker crash on race
Fix gas tracker test for 2.64.1
…2.64 Merge/hotfix 2.64 to release 2.64
The debug_traceCall RPC method was crashing with "method handler crashed" when called with a tracer config that didn't include the Reexec field. Root cause: In TraceCall(), the code checked `if config == nil || isLatest` before using CreateStateReader, but the else branch dereferenced `*config.Reexec` without checking if Reexec was nil. Fix: Add `|| config.Reexec == nil` to the condition to use the current state reader when Reexec is not provided. Also includes defensive checks in the call tracer: - Check for empty callstack in CaptureState before accessing it - Check for empty callstack in CaptureExit before appending - Bounds check in fixLogIndexGap to prevent out-of-bounds access - Added tests for these edge cases
Merge/debug tracecall crash fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.