This repository was archived by the owner on Oct 11, 2024. It is now read-only.
fix small_fib example for indices of 2^x #748
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes small_fib example for indices of format 2^x.
When testing claims with index: 2^x, x >=1, value 1 passes the proof verification. I think the reason is how the trace is constructed.
Trace length is defined as power of two:
But if
self.indexis already power of two,trace_length == self.index. It can be a bit misleading thatnextkeyword returns greater or equal power of twoThus if I change it to
all indices work fine now.
wipwhile in development.bug,enhancement.Changelog.md.https://semver.org/