feat(flake): expose ab as a package output and derive names/versions from Cargo.toml, make ab default package - #19
Merged
Conversation
nothingnesses
force-pushed
the
feat/expose-ab-in-flake
branch
3 times, most recently
from
March 17, 2026 22:48
c9635ec to
5700db8
Compare
…toml Add ab as a flake package output so downstream consumers can reference it directly without inlining their own buildRustPackage definition. Replace hardcoded pname and version strings across all packages with values read from Cargo.toml via builtins.fromTOML, and use rec to reference pname in cargo flags to avoid repetition. Also fix mdbook-excalidraw package reference which incorrectly pointed to pkgs instead of the local derivation.
nothingnesses
force-pushed
the
feat/expose-ab-in-flake
branch
from
March 17, 2026 22:53
5700db8 to
8ab6c3c
Compare
0xferrous
changed the title
ab as a package output and derive names/versions from Cargo.tomlab as a package output and derive names/versions from Cargo.toml, make ab default package
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
abtopackagesso it can be consumed by downstream flakes without inlining their ownbuildRustPackagedefinitionpnameandversionstrings across all packages with values read from Cargo.toml viabuiltins.fromTOML, so version bumps only need to happen in one placerecin each derivation to referencepnamein cargo flags, avoiding repetitionmdbook-excalidrawpackage output, which was incorrectly referencingpkgs.mdbook-excalidraw(doesn't exist in nixpkgs) instead of the local derivationabdefault nix packageWhy
As you know, agent-images uses agent-box as one of its inputs and exposes
abin its dev shell. Currently agent-images has to vendor its ownbuildRustPackagedefinition forabbecause the flake for agent-box doesn't expose it as an output. With this change, agent-images can simply referenceagent-box.packages.${system}.abdirectly.